All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Shift key-related error codes up and insert ECANCELED
Date: Fri, 22 Oct 2004 13:14:27 -0400	[thread overview]
Message-ID: <20041022171427.GN31909@devserv.devel.redhat.com> (raw)
In-Reply-To: <20498.1098464262@redhat.com>

On Fri, Oct 22, 2004 at 05:57:42PM +0100, David Howells wrote:
> 
> This patch shifts the key-related error codes up by one and inserts an
> ECANCELED error code where not already defined. It seems that has been defined
> in glibc without passing it back to the kernel:-/

Not sure what's the story behind ECANCELED not being in kernel headers,
certainly it is something only userland needs ATM.
It is a POSIX mandated errno code used in aio_* that glibc is using
since 1998, so it would be really bad to break all apps using aio.

The values you posted match exactly what glibc is using:

libc/sysdeps/unix/sysv/sysv4/solaris2/bits/errno.h:# define ECANCELED   47      /* Operation canceled.  */
libc/sysdeps/unix/sysv/aix/bits/errno.h:# define ECANCELED      117     /* Asynchronous i/o cancelled.  */
libc/sysdeps/unix/sysv/linux/alpha/bits/errno.h:#  define ECANCELED     131
libc/sysdeps/unix/sysv/linux/sparc/bits/errno.h:#  define ECANCELED     127
libc/sysdeps/unix/sysv/linux/bits/errno.h:#  define ECANCELED   125
libc/sysdeps/unix/sysv/linux/hppa/bits/errno.h:#  define ECANCELED      ECANCELLED
libc/sysdeps/mach/hurd/bits/errno.h:#define     ECANCELED       _HURD_ERRNO (118)/* Operation canceled */

just maybe asm-parisc/errno.h could have
#define ECANCELED ECANCELLED
added (ECANCELED is the POSIX mandated spelling, while asm-parisc/errno.h
for some reason defines ECANCELLED).

	Jakub

  reply	other threads:[~2004-10-22 17:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-22 16:57 [PATCH] Shift key-related error codes up and insert ECANCELED David Howells
2004-10-22 17:14 ` Jakub Jelinek [this message]
2004-10-22 18:34 ` Alan Cox
2004-10-25  9:31   ` David Howells
2004-10-25  9:48     ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041022171427.GN31909@devserv.devel.redhat.com \
    --to=jakub@redhat.com \
    --cc=akpm@osdl.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.