All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	raybry@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: Hugepages demand paging V1 [2/4]: set_huge_pte() arch updates
Date: Fri, 22 Oct 2004 13:45:06 -0700	[thread overview]
Message-ID: <20041022204506.GD17038@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0410221318370.9833@schroedinger.engr.sgi.com>

On Fri, 22 Oct 2004, William Lee Irwin III wrote:
>> What is in fact far more pressing is flush_dcache_page(), without a
>> correct implementation of which for hugetlb, user-visible data
>> corruption follows.

On Fri, Oct 22, 2004 at 01:29:24PM -0700, Christoph Lameter wrote:
> When is flush_dcache_page used on a huge page?
> It seems that the i386 simply does nothing for flush_dcache_page. IA64
> defers to update_mmu_cache by setting PG_arch_1. So these two are ok as
> is.
> The other archs are likely much more involved than this. I tried to find
> an simple way to identify a page as a huge page via struct page but
> that is not that easy and its likely not good to follow
> pointers to pointers in such a critical function. Maybe we need to add a
> new page flag?

It's not done at all for hugepages now, and needs to be. Fault handling
on hugetlb vmas will likely expose the cahing of stale data more readily.


-- wli

  reply	other threads:[~2004-10-22 20:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <B05667366EE6204181EABE9C1B1C0EB501F2ADFB@scsmsx401.amr.corp.intel.com>
2004-10-22  4:55 ` Hugepages demand paging V1 [0/4]: Discussion and overview Christoph Lameter
2004-10-22  4:56   ` Hugepages demand paging V1 [1/4]: demand paging core Christoph Lameter
2004-10-22 10:47     ` William Lee Irwin III
2004-10-22 15:33       ` Christoph Lameter
2004-10-22  4:57   ` Hugepages demand paging V1 [2/4]: set_huge_pte() arch updates Christoph Lameter
2004-10-22 10:37     ` William Lee Irwin III
2004-10-22 15:32       ` Christoph Lameter
2004-10-22 15:42         ` William Lee Irwin III
2004-10-22 20:29           ` Christoph Lameter
2004-10-22 20:45             ` William Lee Irwin III [this message]
2004-10-22 20:49               ` Christoph Lameter
2004-10-22  4:58   ` Hugepages demand paging V1 [3/4]: Overcommit handling Christoph Lameter
2004-10-22 10:28     ` Andrew Morton
2004-10-22 15:08       ` Christoph Lameter
2004-10-22 15:32       ` Chen, Kenneth W
2004-10-22 10:49     ` William Lee Irwin III
2004-10-22 11:01     ` Christoph Hellwig
2004-10-22 11:12       ` William Lee Irwin III
2004-10-22 11:16         ` Christoph Hellwig
2004-10-22 11:21           ` William Lee Irwin III
2004-10-22 11:23             ` William Lee Irwin III
2004-10-22  4:58   ` Hugepages demand paging V1 [4/4]: Numa patch Christoph Lameter
2004-10-22  6:05     ` Chen, Kenneth W
2004-10-22 11:00     ` William Lee Irwin III
2004-10-22 19:37       ` Christoph Lameter
2004-10-22 19:40         ` William Lee Irwin III
2004-10-25 21:25           ` Chen, Kenneth W
2004-10-25 21:52             ` William Lee Irwin III
2004-10-25 21:55               ` William Lee Irwin III
2004-10-25 21:05         ` Chen, Kenneth W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041022204506.GD17038@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=clameter@sgi.com \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raybry@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.