From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Aravamudan Date: Fri, 22 Oct 2004 23:59:41 +0000 Subject: [KJ] [PATCH] cdrom/sonycd535: replace schedule_timeout() with Message-Id: <20041022235941.GO18906@us.ibm.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============024133760160697459==" List-Id: To: kernel-janitors@vger.kernel.org --===============024133760160697459== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Any comments would be, as always, appreciated. -Nish Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan --- 2.6.9-bk7-vanilla/drivers/cdrom/sonycd535.c 2004-10-22 10:41:41.000000000 -0700 +++ 2.6.9-bk7/drivers/cdrom/sonycd535.c 2004-10-22 12:02:21.000000000 -0700 @@ -896,9 +896,8 @@ do_cdu535_request(request_queue_t * q) } if (readStatus == BAD_STATUS) { /* Sleep for a while, then retry */ - set_current_state(TASK_INTERRUPTIBLE); spin_unlock_irq(&sonycd535_lock); - schedule_timeout(RETRY_FOR_BAD_STATUS*HZ/10); + msleep_interruptible(RETRY_FOR_BAD_STATUS*100); spin_lock_irq(&sonycd535_lock); } #if DEBUG > 0 --===============024133760160697459== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============024133760160697459==--