All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@debian.org>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org, Roland McGrath <roland@redhat.com>
Subject: Unwind information fix for the vsyscall DSO
Date: Sun, 24 Oct 2004 19:01:38 -0400	[thread overview]
Message-ID: <20041024230138.GA22543@nevyn.them.org> (raw)

When working on GDB support I found a typo.  I assume the comment is
correct.  If you step to this particular instruction and backtrace, GDB gets
lost.

I haven't tested the fixed version yet, but I'm pretty confident in this
patch :-)  Please apply.

--- arch/i386/kernel/vsyscall-sysenter.S.orig	2004-04-05 21:21:20.000000000 -0400
+++ arch/i386/kernel/vsyscall-sysenter.S	2004-10-24 18:50:54.000000000 -0400
@@ -84,7 +84,7 @@
 	.byte 0x04		/* DW_CFA_advance_loc4 */
 	.long .Lpop_ebp-.Lenter_kernel
 	.byte 0x0e		/* DW_CFA_def_cfa_offset */
-	.byte 0x12		/* RA at offset 12 now */
+	.byte 0x0c		/* RA at offset 12 now */
 	.byte 0xc5		/* DW_CFA_restore %ebp */
 	.byte 0x04		/* DW_CFA_advance_loc4 */
 	.long .Lpop_edx-.Lpop_ebp


-- 
Daniel Jacobowitz

             reply	other threads:[~2004-10-24 23:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-24 23:01 Daniel Jacobowitz [this message]
2004-10-24 23:27 ` Unwind information fix for the vsyscall DSO Linus Torvalds
2004-10-25  2:26   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041024230138.GA22543@nevyn.them.org \
    --to=dan@debian.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.