From: William Lee Irwin III <wli@holomorphy.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>,
Andrea Arcangeli <andrea@novell.com>,
Albert Cahalan <albert@users.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] statm: shared = rss - anon_rss
Date: Mon, 25 Oct 2004 12:30:16 -0700 [thread overview]
Message-ID: <20041025193016.GX17038@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0410241647080.12023-100000@localhost.localdomain>
On Sun, Oct 24, 2004 at 04:49:48PM +0100, Hugh Dickins wrote:
> The third "shared" field of /proc/$pid/statm in 2.4 was a count of pages
> in the mm whose page_count is more than 1 (oddly, including pages shared
> just with swapcache). That's too costly to calculate each time, so 2.6
> changed it to the total file-backed extent. But Andrea knows apps and
> users surprised when (rss - shared) goes negative: we need to provide
> an rss-like statistic, close to the 2.4 interpretation.
> Something that's quick and easy to maintain accurately is mm->anon_rss,
> the count of anonymous pages in the mm. Then shared = rss - anon_rss
> gives a pretty good and meaningful approximation to 2.4's intention:
> wli confirms that this will be useful to Oracle too.
> Where to show it? I think it's best to treat this as a bugfix and show
> it in the third field of /proc/$pid/statm, after resident, as before -
> there's no evidence that the total file-backed extent was found useful.
> Albert would like other fields to revert to page counts, but that's a
> lot harder: if mprotect can change the category of a page, then it can't
> be accounted as simply as this. Only go that route if real need shown.
The group maintaining the tools relying upon the properties of the
shared field of statm at Oracle has gone beyond code inspection of the
patches, and as of today has carried out runtime testing of your
patches and verified that it resolves the issue to their full
satisfaction during runtime operation of the tools.
-- wli
next prev parent reply other threads:[~2004-10-25 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-24 15:45 [PATCH 1/3] statm: __vm_stat_accounting Hugh Dickins
2004-10-24 15:46 ` [PATCH 2/3] statm: fix negative data Hugh Dickins
2004-10-24 16:08 ` William Lee Irwin III
2004-10-24 15:49 ` [PATCH 3/3] statm: shared = rss - anon_rss Hugh Dickins
2004-10-24 16:08 ` William Lee Irwin III
2004-10-25 6:24 ` Andrew Morton
2004-10-25 6:29 ` William Lee Irwin III
2004-10-25 19:30 ` William Lee Irwin III [this message]
2004-10-25 19:48 ` Andrea Arcangeli
2004-10-24 16:08 ` [PATCH 1/3] statm: __vm_stat_accounting William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041025193016.GX17038@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=albert@users.sourceforge.net \
--cc=andrea@novell.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.