From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: kernel@linuxace.com, linux-net@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: 2.6.9 failed assertion in tcp_timer.c
Date: Mon, 25 Oct 2004 21:09:46 -0700 [thread overview]
Message-ID: <20041025210946.367f65be.davem@davemloft.net> (raw)
In-Reply-To: <20041022232403.GA14618@gondor.apana.org.au>
On Sat, 23 Oct 2004 09:24:03 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Actually, I think we've caught your crash now. If that code path
> is triggering at all, then it'll trigger with TSO packets too. If
> we get a truly partial ack on a TSO packet, then tcp_tso_acked will
> not trim it off. So we will fall through to this last-ditch trim
> call, which doesn't update packets_out.
>
> There are two solutions to this problem. I've taken the simpler
> approach for now. We simply trim off the partial bits in tcp_tso_acked
> and live with the fact that the packet counters may differ from
> what's on the netwrok by one.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Later on we can "fix" this by remembering where the original TSO
> packet started from, perhaps in skb->h or somewhere. Dave, is this
> worth it?
I'm going to apply this patch for now.
I think at this point we can generalize TSO processing a bit
better in this code now.
prev parent reply other threads:[~2004-10-26 4:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041019215054.GA17565@linuxace.com>
[not found] ` <E1CK3Az-0004P2-00@gondolin.me.apana.org.au>
[not found] ` <20041020164748.GA20905@linuxace.com>
[not found] ` <20041020212651.GA8534@gondor.apana.org.au>
[not found] ` <20041020225536.GA22179@linuxace.com>
[not found] ` <20041021130339.GA19345@gondor.apana.org.au>
[not found] ` <20041021165224.GA25399@linuxace.com>
2004-10-21 21:57 ` 2.6.9 failed assertion in tcp_timer.c Herbert Xu
2004-10-22 5:53 ` David S. Miller
2004-10-22 18:54 ` Phil Oester
2004-10-22 21:50 ` Herbert Xu
2004-10-22 22:12 ` David S. Miller
2004-10-22 23:24 ` Herbert Xu
2004-10-25 19:58 ` Phil Oester
2004-10-25 20:25 ` David S. Miller
2004-10-26 4:09 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041025210946.367f65be.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@linuxace.com \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.