From: Pavel Machek <pavel@ucw.cz>
To: Chris Wedgwood <cw@f00f.org>
Cc: "Zhu, Yi" <yi.zhu@intel.com>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [swsusp] print error message when swapping is disabled (fwd)
Date: Tue, 26 Oct 2004 11:14:49 +0200 [thread overview]
Message-ID: <20041026091449.GA28897@elf.ucw.cz> (raw)
In-Reply-To: <20041026023858.GA7467@taniwha.stupidest.org>
Hi!
> > + if ((error = swsusp_swap_check())) {
> > + printk(KERN_ERR "swsusp: FATAL: cannot find swap device, try "
> > + "swapon -a!\n");
>
> maybe it's just me, but i would really prefer to have the occasional
> long(er) line that splitting strings like that
It is not just you :-). Also it should probably not have KERN_ERR
level (it is not really error, you just asked for something that can
not be done) and word FATAL scares me.
But it is probably easier to put there some message first then fix it
up.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-10-26 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 2:01 [PATCH] [swsusp] print error message when swapping is disabled (fwd) Zhu, Yi
2004-10-26 2:38 ` Chris Wedgwood
2004-10-26 9:14 ` Pavel Machek [this message]
2004-10-26 9:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041026091449.GA28897@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=cw@f00f.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.