All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Anderson <ryan@michonline.com>
To: David Vrabel <dvrabel@arcom.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Len Brown <len.brown@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Versioning of tree
Date: Tue, 26 Oct 2004 08:26:33 -0400	[thread overview]
Message-ID: <20041026122632.GH10638@michonline.com> (raw)
In-Reply-To: <417E39AE.5020209@arcom.com>

On Tue, Oct 26, 2004 at 12:49:02PM +0100, David Vrabel wrote:
> Ryan Anderson wrote:
> >
> >Well, here's a patch that adds -BKxxxxxxxx to LOCALVERSION when a
> >top-level BitKeeper tree is detected.
> >[...]
> > LOCALVERSION = $(subst $(space),, \
> > 	       $(shell cat /dev/null $(localversion-files)) \
> >+	       $(subst ",,$(localversion-bk)) \
> 
> Surely there's no need for this?  Can't the script spit out an 
> appropriate localversion* file instead?

It can, and yes, my first version used that method.

Except it never worked.  I was able to generate the file before
include/linux/version.h was rebuilt, but failed to get it picked up in
that.  I'm not really sure why.

For what it's worth, "make deb-pkg" picks up the version correctly using
this method:
	dpkg-deb: building package `linux-2.6.10-rc1-bkd581e3d1' in
	`../linux-2.6.10-rc1-bkd581e3d1_2.6.10-rc1-BKd581e3d1_i386.deb'.

> Tools like Debian's make-kpkg have to work out the kernel version (for 
> use in the package name etc.) and it would be preferable if the method 
> for generating the version didn't change too often.

Well, I didn't think make-kpkg was doing anything horribly unexpected,
so I didn't to test that.   I'll do a test run now to see what happens,
though.

-- 

Ryan Anderson
  sometimes Pug Majere

  reply	other threads:[~2004-10-26 12:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-20  6:49 Versioning of tree Benjamin Herrenschmidt
2004-10-20  7:22 ` Len Brown
2004-10-20 14:33   ` Linus Torvalds
2004-10-21  1:38     ` Benjamin Herrenschmidt
2004-10-21 15:33     ` Måns Rullgård
2004-10-21 15:48       ` Linus Torvalds
2004-10-21 16:49     ` Jeff Garzik
2004-10-21 17:10       ` Linus Torvalds
2004-10-21 23:03         ` kbuild (was Re: Versioning of tree) Jeff Garzik
2004-10-30 23:34           ` Sam Ravnborg
2004-10-25 23:47     ` Versioning of tree Ryan Anderson
2004-10-26 11:49       ` David Vrabel
2004-10-26 12:26         ` Ryan Anderson [this message]
2004-10-26 12:58           ` David Vrabel
2004-10-26 19:08           ` Sam Ravnborg
2004-10-26 18:04             ` Ryan Anderson
2004-10-26 19:11               ` Ian Campbell
2004-10-27  8:38             ` Ryan Anderson
2004-10-27 11:37               ` Sam Ravnborg
2004-10-20  8:22 ` Jeff Garzik
2004-10-20  8:39   ` Benjamin Herrenschmidt
2004-10-20 10:36 ` Måns Rullgård
  -- strict thread matches above, loose matches on Subject: below --
2004-10-20 18:27 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041026122632.GH10638@michonline.com \
    --to=ryan@michonline.com \
    --cc=benh@kernel.crashing.org \
    --cc=dvrabel@arcom.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.