From: Jens Axboe <axboe@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-ide@vger.kernel.org
Subject: Re: [BK PATCH] 2.6.x libata bug fix
Date: Tue, 26 Oct 2004 19:30:26 +0200 [thread overview]
Message-ID: <20041026173025.GA15290@suse.de> (raw)
In-Reply-To: <20041026160247.GA23459@havoc.gtf.org>
On Tue, Oct 26 2004, Jeff Garzik wrote:
>
> When I added ioctl handling, I returned EOPNOTSUPP for the "I didn't
> recognize that ioctl you wanted to execute" return code.
>
> The block layer will execute certain ioctl operations IFF the low-level
> driver returns ENOTTY, signalling to the block layer that that driver
> does not support the specified ioctl.
>
> The net effect of libata returning EOPNOTSUPP was such that it
> __broke__ BLSFLSBUF ioctl, simply by implementing ->ioctl.
>
> So, we return the proper return code, and ioctls we don't handle
> start to work again. Overall, though, this is a fragile way to do
> things in the block layer, IMHO.
Well, it's pretty much the universally accepted way of signalling this
information, I'm not sure I agree. The crappy part is that EINVAL is so
wide spread as well.
And EOPNOTSUPP just shows you are a networking whore as well :-)
--
Jens Axboe
next prev parent reply other threads:[~2004-10-26 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 16:02 [BK PATCH] 2.6.x libata bug fix Jeff Garzik
2004-10-26 17:30 ` Jens Axboe [this message]
2004-10-26 17:45 ` Jeff Garzik
2004-10-26 17:56 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2004-10-27 0:00 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041026173025.GA15290@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.