All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: davem@davemloft.net, netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/3] net: generic netdev_ioaddr
Date: Fri, 29 Oct 2004 12:52:33 +0100	[thread overview]
Message-ID: <20041029115233.GA11391@infradead.org> (raw)
In-Reply-To: <1099044244.9566.0.camel@localhost>

On Fri, Oct 29, 2004 at 01:04:04PM +0300, Pekka Enberg wrote:
> Hi,
> 
> This patch introduces a generic netdev_ioaddr and converts natsemi and
> 8139too drivers to use it.
> 
> With the recent __iomem annotations, the network drivers need to either
> invent this wrapper (like natsemi has done) or duplicate the IO base
> address in their private data (similar to 8139too).  Therefore, lets
> make netdev_ioaddr generic before it is all over the place.

This casting around sounds like a bad idea.  Either add another

	void __iomem *mmioaddr;

member to struct net_device, or better move that completely into the
driver-private structure which seems the better level of abstraction.


  parent reply	other threads:[~2004-10-29 11:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-29 10:04 [RFC][PATCH 0/3] net: generic netdev_ioaddr Pekka Enberg
2004-10-29 10:04 ` [PATCH 1/3] " Pekka Enberg
2004-10-29 10:05   ` [PATCH 2/3] net: use netdev_ioaddr in natsemi Pekka Enberg
2004-10-29 10:05     ` [PATCH 3/3] net: use netdev_ioaddr in 8139too Pekka Enberg
2004-10-29 11:52 ` Christoph Hellwig [this message]
2004-10-29 13:16 ` [RFC][PATCH 0/3] net: generic netdev_ioaddr Al Viro
2004-10-29 18:50   ` Pekka J Enberg
2004-10-29 19:18     ` Krzysztof Halasa
2004-10-29 19:38       ` Al Viro
2004-10-29 21:13         ` Krzysztof Halasa
2004-10-30  9:52           ` Pekka Enberg
2004-10-31  1:02             ` Krzysztof Halasa
2004-10-31  7:11               ` Pekka Enberg
2004-10-31 23:14                 ` Krzysztof Halasa
2004-11-01 14:27                   ` Pekka Enberg
2004-10-29 20:01   ` [PATCH] net: fix natsemi base_addr casting Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041029115233.GA11391@infradead.org \
    --to=hch@infradead.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.