From: Andi Kleen <ak@suse.de>
To: Tom Rini <trini@kernel.crashing.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: [patch 7/8] KGDB support for x86_64
Date: Sat, 30 Oct 2004 01:13:22 +0200 [thread overview]
Message-ID: <20041029231322.GD31914@wotan.suse.de> (raw)
In-Reply-To: <7.29102004.trini@kernel.crashing.org>
On Fri, Oct 29, 2004 at 11:34:21AM -0700, Tom Rini wrote:
>
> Cc: Andi Kleen <ak@suse.de>
> This adds KGDB support for x86_64.
Can you please explain what the additional hooks are good for?
> +++ linux-2.6.10-rc1-trini/arch/x86_64/kernel/Makefile 2004-10-29 11:26:45.757144605 -0700
> @@ -10,6 +10,8 @@ obj-y := process.o semaphore.o signal.o
> setup64.o bootflag.o e820.o reboot.o warmreboot.o
> obj-y += mce.o
>
> +CFLAGS_vsyscall.o := -g0
> +
What's this?
> +#include <linux/kgdb.h>
> #include <asm/uaccess.h>
> #include <asm/io_apic.h>
>
> @@ -103,6 +104,13 @@ asmlinkage unsigned int do_IRQ(struct pt
> __do_IRQ(irq, regs);
> irq_exit();
>
> + /*
> + * Do not call breakpoint as on the x86_64 architecture if the
> + * exception tables are not set.
> + */
> + if(CHECK_EXCEPTION_STACK())
> + kgdb_process_breakpoint();
> +
And that? Why do you need to check breakpoints in interrupts?
> #include <linux/moduleparam.h>
> +#include <linux/debugger.h>
>
> #include <asm/system.h>
> #include <asm/uaccess.h>
> @@ -642,7 +643,7 @@ asmlinkage void *do_debug(struct pt_regs
> tsk->thread.debugreg6 = condition;
>
> /* Mask out spurious TF errors due to lazy TF clearing */
> - if (condition & DR_STEP) {
> + if (condition & DR_STEP && !debugger_step) {
This also looks bogus. What is this exactly for and why is it not
handled through the debug chain?
-Andi
next prev parent reply other threads:[~2004-10-29 23:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 18:32 [patch 1/8] A different KGDB stub for -mm Tom Rini
2004-10-29 18:33 ` [patch 2/8] KGDB support for i386 Tom Rini
2004-10-29 18:33 ` [patch 3/8] KGDB support for ppc32 Tom Rini
2004-10-29 18:33 ` [patch 4/8] 8250 uart driver for KGDB Tom Rini
2004-10-29 18:33 ` [patch 5/8] KGDB support for MIPS Tom Rini
2004-10-29 18:34 ` [patch 6/8] KGDB support for ia64 Tom Rini
2004-10-29 18:34 ` [patch 7/8] KGDB support for x86_64 Tom Rini
2004-10-29 18:34 ` [patch 8/8] KGDB over ethernet driver Tom Rini
2004-10-29 23:13 ` Andi Kleen [this message]
2004-10-30 19:05 ` [patch 3/8] KGDB support for ppc32 Tom Rini
2004-10-29 18:35 ` [patch 1/8] A different KGDB stub for -mm Tom Rini
2004-10-29 19:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041029231322.GD31914@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.