[parisc-linux] Re: How to determine whether a device is PCI or not

[Greg KH <greg@kroah.com>]

On Wed, Oct 27, 2004 at 03:15:22PM +0100, Matthew Wilcox wrote:
> On Wed, Oct 27, 2004 at 03:32:16PM +0200, Joel Soete wrote:
> >  	while (dev != &root) {
> > +#ifdef CONFIG_PCI
> >  		if (dev->bus == &pci_bus_type) {
> >  			unsigned int devfn = to_pci_dev(dev)->devfn;
> >  			path->bc[i--] = PCI_SLOT(devfn) | (PCI_FUNC(devfn)<< 5);
> >  		} else if (dev->bus == &parisc_bus_type) {
> > +#else
> > +		if (dev->bus == &parisc_bus_type) {
> > +#endif
> >  			path->bc[i--] = to_parisc_device(dev)->hw_path;
> >  		}
> >  		dev = dev->parent;
> 
> The problem here is that pci_bus_type is declared inside an #ifdef
> CONFIG_PCI.  What we *actually* want to know is "is this device a
> pci_dev?"  and this isn't the best way to ask this question.  How about
> we add exactly that question to <linux/pci.h>, something like:

Ick, no.  Devices do not "show" their type, you have to explicitly know
what type they are in order to use them.

Why are you wanting to know this?  What are you trying to do with a
generic struct device * where you don't know exactly what type it is?

thanks,

greg k-h

p.s. bonus points to the first person who finds in the kernel where I
myself have violated the second sentance in this response :)
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux