From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Andreas Herrmann <AHERRMAN@de.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Subject: Re: [PATCH] reduce stack consumption in do_mount
Date: Sat, 30 Oct 2004 14:14:53 -0200 [thread overview]
Message-ID: <20041030161453.GA17602@logos.cnet> (raw)
In-Reply-To: <OF2D3B25A6.EBF2AF62-ONC1256F3B.005D01ED-C1256F3B.005EBAFF@de.ibm.com>
On Thu, Oct 28, 2004 at 07:14:52PM +0200, Andreas Herrmann wrote:
> I have seen a kernel stack overflow during mount of a SCSI disk on
> s390, 31bit, with 4K stack size.
>
> The backtrace showed that there were 3 functions with stack
> consumption of above 200 bytes.
>
> These are do_mount (328 bytes stack size), ext3_fill_super (288 bytes)
> and mpage_writepages (352 bytes).
One possibly interesting thing for you guys who are trying to reduce
stack usage is using the SLAB allocator for pagevec structures in the VM
code. mpage_readpages/writepages use those, and pretty much all VM code.
Allocating those structures from SLAB can also increase performance
due to cache colouring, but requires the additional instructions into
kmalloc() for allocation - needs benchmarking.
I want to try so if no one does it before.
next prev parent reply other threads:[~2004-10-30 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 17:14 [PATCH] reduce stack consumption in do_mount Andreas Herrmann
2004-10-28 20:31 ` Denis Vlasenko
2004-10-30 16:14 ` Marcelo Tosatti [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-29 14:29 Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041030161453.GA17602@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=AHERRMAN@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.