From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: janitor@sternwelten.at, netdev@oss.sgi.com
Subject: Re: [patch 05/18] net/s2io: replace schedule_timeout() with msleep()
Date: Mon, 1 Nov 2004 10:31:18 -0800 [thread overview]
Message-ID: <20041101183118.GA1730@us.ibm.com> (raw)
In-Reply-To: <4184C7EE.5070107@pobox.com>
On Sun, Oct 31, 2004 at 06:09:34AM -0500, Jeff Garzik wrote:
> janitor@sternwelten.at wrote:
> >@@ -2846,11 +2838,10 @@ static int s2io_ethtool_idnic(struct net
> > sp->id_timer.data = (unsigned long) sp;
> > }
> > mod_timer(&sp->id_timer, jiffies);
> >- set_current_state(TASK_INTERRUPTIBLE);
> > if (data)
> >- schedule_timeout(data * HZ);
> >+ msleep_interruptible(data * 1000);
>
>
> clearly wants ssleep() here
Even though ssleep() is in TASK_UNINTERRUPTIBLE? In cases where the
existing code used TASK_INTERRUPTIBLE, but was sleeping in terms of
seconds, I left it as msleep_interruptible, since ssleep_interruptible()
doesn't exist.
-Nish
next prev parent reply other threads:[~2004-11-01 18:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 22:42 [patch 05/18] net/s2io: replace schedule_timeout() with msleep() janitor
2004-10-31 11:09 ` Jeff Garzik
2004-11-01 18:31 ` Nishanth Aravamudan [this message]
2004-11-01 18:03 ` Jeff Garzik
2004-11-01 19:14 ` Nishanth Aravamudan
2004-11-01 19:23 ` [KJ] [PATCH] net/s2io: replace schedule_timeout() with Nishanth Aravamudan
2004-11-01 20:20 ` [PATCH] net/s2io: replace schedule_timeout() with msleep()/ssleep_interruptible() Nishanth Aravamudan
2004-11-01 19:18 ` [KJ] [PATCH] Add ssleep_interruptible() Nishanth Aravamudan
2004-11-01 20:07 ` Nishanth Aravamudan
2004-11-17 1:30 ` [KJ] " Nishanth Aravamudan
2004-11-17 1:30 ` Nishanth Aravamudan
2004-11-22 2:48 ` [KJ] " Horms
2004-11-22 2:48 ` Horms
2004-11-22 17:19 ` [KJ] " Nishanth Aravamudan
2004-11-22 17:19 ` Nishanth Aravamudan
2004-11-24 2:01 ` [KJ] " Horms
2004-11-24 2:01 ` Horms
2004-11-24 18:16 ` [KJ] " Nishanth Aravamudan
2004-11-24 18:16 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041101183118.GA1730@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=janitor@sternwelten.at \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.