Re: [PATCH 8/14] FRV: GP-REL data support

[Christoph Hellwig <hch@infradead.org>]

> --- /warthog/kernels/linux-2.6.10-rc1-bk10/include/linux/jiffies.h	2004-10-27 17:32:36.000000000 +0100
> +++ linux-2.6.10-rc1-bk10-frv/include/linux/jiffies.h	2004-11-01 11:47:05.112636819 +0000
> @@ -70,13 +70,23 @@
>  /* a value TUSEC for TICK_USEC (can be set bij adjtimex)		*/
>  #define TICK_USEC_TO_NSEC(TUSEC) (SH_DIV (TUSEC * USER_HZ * 1000, ACTHZ, 8))
>  
> +/* some arch's have a small-data section that can be accessed register-relative
> + * but that can only take up to, say, 4-byte variables. jiffies being part of
> + * an 8-byte variable may not be correctly accessed unless we force the issue
> + */
> +#ifdef CONFIG_FRV
> +#define __jiffy_data  __attribute__((section(".data")))
> +#else
> +#define __jiffy_data
> +#endif

please avoid per-arch ifdefs in common code, this needs to go into some asm/
header, or and __ARCH_HAVE_FOO ifdef.  Anyway, would doing this
unconditionally cause any problems?

> diff -uNr /warthog/kernels/linux-2.6.10-rc1-bk10/include/linux/linkage.h linux-2.6.10-rc1-bk10-frv/include/linux/linkage.h
> --- /warthog/kernels/linux-2.6.10-rc1-bk10/include/linux/linkage.h	2004-10-19 10:42:16.000000000 +0100
> +++ linux-2.6.10-rc1-bk10-frv/include/linux/linkage.h	2004-11-01 11:47:05.114636652 +0000
> @@ -44,4 +44,8 @@
>  #define fastcall
>  #endif
>  
> +#ifndef __ASSEMBLY__
> +extern const char linux_banner[];
> +#endif

totally wrong place.  this is not about linkage at all.