From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Christoph Hellwig <hch@lst.de>,
jejb@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] convert eata to pass pointers around
Date: Tue, 2 Nov 2004 16:07:57 +0100 [thread overview]
Message-ID: <20041102150757.GA32497@lst.de> (raw)
In-Reply-To: <20041102145418.GA24690@parcelfarce.linux.theplanet.co.uk>
On Tue, Nov 02, 2004 at 02:54:18PM +0000, Matthew Wilcox wrote:
> On Tue, Nov 02, 2004 at 03:33:51PM +0100, Christoph Hellwig wrote:
> > @@ -836,7 +836,7 @@
> > struct mssp sp; /* Local copy of sp buffer */
> > };
> >
> > -static struct Scsi_Host *sh[MAX_BOARDS + 1];
> > +struct Scsi_Host *sh[MAX_BOARDS];
> > static const char *driver_name = "EATA";
> > static char sha[MAX_BOARDS];
> > static spinlock_t driver_lock = SPIN_LOCK_UNLOCKED;
>
> Did you mean to un-static 'sh'? This seems like an awfully vague
> name to make kernel-global ...
no. but it'll be gone completely in one of the next patches.
next prev parent reply other threads:[~2004-11-02 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 14:33 [PATCH] convert eata to pass pointers around Christoph Hellwig
2004-11-02 14:54 ` Matthew Wilcox
2004-11-02 15:07 ` Christoph Hellwig [this message]
2004-11-03 12:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041102150757.GA32497@lst.de \
--to=hch@lst.de \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.