From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: [Alsa-devel] [PATCH] sound/cs4231_lib: replace
Date: Wed, 03 Nov 2004 17:56:50 +0000 [thread overview]
Message-ID: <20041103175650.GD2163@us.ibm.com> (raw)
In-Reply-To: <Pine.HPX.4.33n.0411031010440.25361-100000@studcom.urz.uni-halle.de>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On Wed, Nov 03, 2004 at 10:22:34AM +0100, Clemens Ladisch wrote:
> Nishanth Aravamudan wrote:
> > [...]
> > How about the following patch?
>
> Applied, with some changes (see below).
>
> > I used TASK_UNINTERRUPTIBLE (i.e. msleep()). This, though, will
> > guarantee that the task sleeps *at least* the requested time (20
> > ms per iteration). This may lead to a longer delay than desired,
> > for instance, if perhaps the condition should be checked after
> > each signal.
>
> This code was never intended to handle signals; using
> TASK_INTERRUPTIBLE was a bug.
>
> 20 ms happens to be the usual calibration time of the original CS4231
> chip (so it was expected to stop after the first iteration), but there
> are many clones that might need a slightly different time, so I
> changed it to 10 ms. However, this doesn't really matter. :)
>
> Finally, I removed the time variable because it wasn't used anymore.
Great,i
Acked-by: Nishanth Aravamudan <nacc@us.ibm.com>
I will resend the sparc patch now.
-Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-11-03 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 19:29 [KJ] [PATCH] sound/cs4231_lib: replace schedule_timeout() with Nishanth Aravamudan
2004-11-03 9:22 ` [PATCH] sound/cs4231_lib: replace schedule_timeout() with msleep() Clemens Ladisch
2004-11-03 9:22 ` [KJ] Re: [Alsa-devel] [PATCH] sound/cs4231_lib: replace Clemens Ladisch
2004-11-03 9:31 ` [KJ] Re: [Alsa-devel] [PATCH] sound/cs4231: replace Clemens Ladisch
2004-11-03 18:03 ` [PATCH] sound/cs4231: replace schedule_timeout() with msleep_interruptible() Nishanth Aravamudan
2004-11-03 17:56 ` [PATCH] sound/cs4231_lib: replace schedule_timeout() with msleep() Nishanth Aravamudan
2004-11-03 17:56 ` Nishanth Aravamudan [this message]
2004-11-03 18:03 ` [KJ] Re: [Alsa-devel] [PATCH] sound/cs4231: replace Nishanth Aravamudan
2004-11-04 7:58 ` [PATCH] sound/cs4231: replace schedule_timeout() with msleep_interruptible() Clemens Ladisch
2004-11-04 7:58 ` [KJ] Re: [Alsa-devel] [PATCH] sound/cs4231: replace Clemens Ladisch
-- strict thread matches above, loose matches on Subject: below --
2004-11-02 19:40 [KJ] [PATCH] sound/cs4231: replace schedule_timeout() with Nishanth Aravamudan
2004-11-03 9:31 ` [PATCH] sound/cs4231: replace schedule_timeout() with msleep_interruptible() Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041103175650.GD2163@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.