All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Michael J. Cohen" <mjc@unre.st>
Cc: "K.R. Foley" <kr@cybsft.com>,
	sboyce@blueyonder.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm2-V0.7.7
Date: Thu, 4 Nov 2004 12:17:13 +0100	[thread overview]
Message-ID: <20041104111713.GA32306@elte.hu> (raw)
In-Reply-To: <1099563805.30372.2.camel@localhost>


* Michael J. Cohen <mjc@unre.st> wrote:

> Ingo
> 	Great timing! only 7 minutes after I posted my concession speech. ;)
> 
> Here you go:
> 
>   LD      .tmp_vmlinux1
> kernel/built-in.o(.text+0x1e57c): In function `___trace':
> : undefined reference to `irqs_disabled_flags'
> kernel/built-in.o(.text+0x1e797): In function `add_preempt_count':
> : undefined reference to `irqs_disabled_flags'
> make: *** [.tmp_vmlinux1] Error 1

the patch below should fix this - but i'd suggest to disable
LATENCY_TRACING, i had bad experience with x86_64 gcc & mcount. (it was
not possible to get a working -pg and -fno-omit-frame-pointers at once.)

	Ingo

--- linux/include/asm-x86_64/system.h.orig
+++ linux/include/asm-x86_64/system.h
@@ -316,11 +316,16 @@ static inline unsigned long __cmpxchg(vo
 /* used in the idle loop; sti takes one instruction cycle to complete */
 #define safe_halt()		__asm__ __volatile__("sti; hlt": : :"memory")
 
+#define irqs_disabled_flags(flags)	\
+({					\
+	!(flags & (1<<9));		\
+})
+
 #define irqs_disabled()			\
 ({					\
 	unsigned long flags;		\
 	local_save_flags(flags);	\
-	!(flags & (1<<9));		\
+	irqs_disabled_flags(flags);	\
 })
 
 /* For spinlocks etc */

  reply	other threads:[~2004-11-04 11:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-03 17:08 [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm2-V0.7.7 Sid Boyce
2004-11-03 18:51 ` K.R. Foley
2004-11-04  0:00   ` Sid Boyce
2004-11-04  1:40     ` K.R. Foley
2004-11-04  9:59       ` Michael J. Cohen
2004-11-04 10:06       ` Ingo Molnar
2004-11-04 10:23         ` Michael J. Cohen
2004-11-04 11:17           ` Ingo Molnar [this message]
2004-11-04 11:17           ` Michael J. Cohen
2004-11-04 11:45             ` Ingo Molnar
2004-11-04 12:59               ` Michael J. Cohen
2004-11-04 13:34                 ` Michael J. Cohen
2004-11-04 14:05                   ` Ingo Molnar
2004-11-04 14:13                     ` Michael J. Cohen
2004-11-04 14:23                       ` Ingo Molnar
2004-11-04 18:31                         ` Michael J. Cohen
2004-11-04 19:38                           ` Ingo Molnar
2004-11-05 12:16                             ` Sid Boyce
2004-11-05 19:53                             ` Michael J. Cohen
2004-11-06  7:36                               ` Ingo Molnar
2004-11-04 12:53         ` Sid Boyce
  -- strict thread matches above, loose matches on Subject: below --
2004-11-03 20:40 [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm2-V0.7.1 Mark_H_Johnson
2004-11-04  0:17 ` [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm2-V0.7.7 Rui Nuno Capela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041104111713.GA32306@elte.hu \
    --to=mingo@elte.hu \
    --cc=kr@cybsft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjc@unre.st \
    --cc=sboyce@blueyonder.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.