All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Roland Dreier <roland@topspin.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	Germano <germano.barreiro@cyclades.com>,
	Scott_Kilau@digi.com, linux-kernel@vger.kernel.org
Subject: Re: patch for sysfs in the cyclades driver
Date: Thu, 4 Nov 2004 09:44:11 -0800	[thread overview]
Message-ID: <20041104174411.GE16389@kroah.com> (raw)
In-Reply-To: <523bzpo6m2.fsf@topspin.com>

On Thu, Nov 04, 2004 at 09:40:21AM -0800, Roland Dreier wrote:
>     Marcelo> ------ Greg answer was:
> 
>     Greg> For a driver only attribute, you want them to show up in the
>     Greg> place for the driver (like under
>     Greg> /sys/bus/pci/driver/MY_FOO_DRIVER/).  To do that use the
>     Greg> DRIVER_ATTR() and the driver_add_file() functions.  For
>     Greg> examples, see the other drivers that use these functions.
> 
> I think Greg may have misunderstood the question and told you how to
> expose per-driver attributes.  But I think the attributes you want
> really are per-device and should be attached to the class_device, not
> the driver.

Heh, yes.  Per-driver attributes go in the driver's directory.  Per port
attributes go in the port's directory.  Simple as that :)

thanks,

greg k-h

  reply	other threads:[~2004-11-04 18:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-03 13:09 patch for sysfs in the cyclades driver Germano
2004-11-04 10:25 ` Marcelo Tosatti
2004-11-04 16:58   ` Roland Dreier
2004-11-04 14:29     ` Marcelo Tosatti
2004-11-04 17:40       ` Roland Dreier
2004-11-04 17:44         ` Greg KH [this message]
2004-11-04 17:42       ` Greg KH
2004-11-04 17:40     ` Greg KH
2004-11-04 19:05       ` Roland Dreier
2004-11-04 19:17         ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2004-11-04 17:50 Kilau, Scott
2004-11-04 18:28 ` Germano
2004-11-04 16:40 Kilau, Scott
2004-11-04 17:39 ` Greg KH
2004-11-03 22:35 Kilau, Scott
2004-11-03 23:08 ` Greg KH
2004-11-03 20:20 Kilau, Scott
2004-11-03 21:23 ` Greg KH
2004-11-03 19:55 Kilau, Scott
2004-11-03 20:03 ` Greg KH
     [not found] <71A17D6448EC0140B44BCEB8CD0DA36E04B9D812@minimail.digi.com>
2004-11-03  2:28 ` Greg KH
2004-10-28 18:56 Germano Barreiro
2004-10-30  4:40 ` Greg KH
2004-11-01 17:01   ` germano.barreiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041104174411.GE16389@kroah.com \
    --to=greg@kroah.com \
    --cc=Scott_Kilau@digi.com \
    --cc=germano.barreiro@cyclades.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=roland@topspin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.