From: Stelian Pop <stelian@popies.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.de>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH RESEND] pcmcia network drivers cleanup
Date: Fri, 5 Nov 2004 09:32:29 +0100 [thread overview]
Message-ID: <20041105083229.GC3996@deep-space-9.dsnet> (raw)
In-Reply-To: <418AE490.1010304@pobox.com>
On Thu, Nov 04, 2004 at 09:25:20PM -0500, Jeff Garzik wrote:
> Stelian Pop wrote:
> >Hi,
> >
> >The attached patch:
> > * cleans up the parameter passing (module_param() instead of
> > MODULE_PARM()
> > * makes debugging work (PCMCIA_DEBUG does not exist anymore, make the
> > Makefile test for CONFIG_PCMCIA_DEBUG and activate DEBUG in CFLAGS)
> > and use the same debugging macros for every driver through code
> > reuse.
>
> Comments:
>
> 1) Can you please separate module_param() and PCMCIA_DEBUG patches?
I will and resubmit later. The two changes were a bit related
(modifying the debugging made me do the module_param() cleanup
because MODULE_PARM() and module_param() aren't both allowed
in the same module) that's why I originaly submitted a single patch.
> 2) why not use pr_debug()?
Because pr_debug doesn't take into account the verbosity level
like pn_dbg() does. A lot of drivers in drivers/pcmcia/ do use
such a construction...
Stelian.
--
Stelian Pop <stelian@popies.net>
next prev parent reply other threads:[~2004-11-05 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-04 11:27 [PATCH RESEND] pcmcia network drivers cleanup Stelian Pop
2004-11-05 2:25 ` Jeff Garzik
2004-11-05 8:32 ` Stelian Pop [this message]
2004-11-10 15:59 ` Stelian Pop
2004-11-10 16:00 ` [PATCH] drivers/net/pcmcia: use module_param() instead of MODULE_PARM() Stelian Pop
2004-11-10 16:35 ` Randy.Dunlap
2004-11-10 19:52 ` Stelian Pop
2004-11-10 19:47 ` Randy.Dunlap
2004-11-10 21:21 ` Stelian Pop
2004-11-13 22:44 ` Dominik Brodowski
2004-11-10 16:01 ` [PATCH] drivers/net/pcmcia: rework debugging Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041105083229.GC3996@deep-space-9.dsnet \
--to=stelian@popies.net \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.