From: Ingo Molnar <mingo@elte.hu>
To: andyliu <liudeyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH]add an ifdef in sched.c
Date: Fri, 5 Nov 2004 13:06:15 +0100 [thread overview]
Message-ID: <20041105120615.GA5034@elte.hu> (raw)
In-Reply-To: <aad1205e04110504023d53ce65@mail.gmail.com>
* andyliu <liudeyan@gmail.com> wrote:
> -#define for_each_domain(cpu, domain) \
> +#ifdef CONFIG_SMP
> +# define for_each_domain(cpu, domain) \
> for (domain = cpu_rq(cpu)->sd; domain; domain = domain->parent)
> +#endif
why? A macro hanging around does not cause any bigger code - and the
#ifdef certainly makes the code less readable.
Ingo
prev parent reply other threads:[~2004-11-05 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 12:02 [PATCH]add an ifdef in sched.c andyliu
2004-11-05 12:06 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041105120615.GA5034@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liudeyan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.