2.6.10-rc1-mm3: drm_ati_pcigart_{init,cleanup} multiple definition

[Adrian Bunk <bunk@stusta.de>]

On Fri, Nov 05, 2004 at 12:13:28AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.10-rc1-mm2:
>...
>  bk-drm.patch
>...

This causes the following compile error:

<--  snip  -->

...
  LD      drivers/char/drm/built-in.o
drivers/char/drm/radeon.o(.text+0x120): In function `drm_ati_pcigart_init':
: multiple definition of `drm_ati_pcigart_init'
drivers/char/drm/r128.o(.text+0x120): first defined here
drivers/char/drm/radeon.o(.text+0x350): In function `drm_ati_pcigart_cleanup':
: multiple definition of `drm_ati_pcigart_cleanup'
drivers/char/drm/r128.o(.text+0x350): first defined here
make[3]: *** [drivers/char/drm/built-in.o] Error 1

<--  snip  -->


The definition of non-inline functions in drivers/char/drm/ati_pcigart.h 
is not a good idea.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed