From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CQlBQ-0008CI-KB for qemu-devel@nongnu.org; Sun, 07 Nov 2004 06:26:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CQlBO-0008As-0t for qemu-devel@nongnu.org; Sun, 07 Nov 2004 06:26:06 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CQlBN-0008Ae-Ol for qemu-devel@nongnu.org; Sun, 07 Nov 2004 06:26:05 -0500 Received: from [195.184.98.160] (helo=virtualhost.dk) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CQl33-0001YM-Rf for qemu-devel@nongnu.org; Sun, 07 Nov 2004 06:17:30 -0500 Date: Sun, 7 Nov 2004 12:16:55 +0100 From: Jens Axboe Subject: Re: [Qemu-devel] enabling bus-master IDE driver Message-ID: <20041107111655.GG29120@suse.de> References: <20041107092132.GC29120@suse.de> <20041107093842.GD29120@suse.de> <200411071301.37636.hetz@softier.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411071301.37636.hetz@softier.com> Sender: Jens Axboe Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hetz Ben Hamo Cc: qemu-devel@nongnu.org On Sun, Nov 07 2004, Hetz Ben Hamo wrote: > > > > - put_le16(p + 49, 1 << 9); /* LBA supported, no DMA */ > > > > + put_le16(p + 49, 1 << 9 | 1 << 8); /* DMA and LBA supported */ > > Care to put all the changes in 1 patch please, so I can put it on my web site? Here you go. Index: hw/ide.c =================================================================== RCS file: /cvsroot/qemu/qemu/hw/ide.c,v retrieving revision 1.28 diff -u -r1.28 ide.c --- hw/ide.c 9 Oct 2004 20:27:55 -0000 1.28 +++ hw/ide.c 7 Nov 2004 11:19:52 -0000 @@ -416,10 +416,10 @@ put_le16(p + 47, 0x8000 | MAX_MULT_SECTORS); #endif put_le16(p + 48, 1); /* dword I/O */ - put_le16(p + 49, 1 << 9); /* LBA supported, no DMA */ + put_le16(p + 49, 1 << 9 | 1 << 8); /* DMA and LBA supported */ put_le16(p + 51, 0x200); /* PIO transfer cycle */ put_le16(p + 52, 0x200); /* DMA transfer cycle */ - put_le16(p + 53, 1); /* words 54-58 are valid */ + put_le16(p + 53, 1 | 1 << 2); /* words 54-58,88 are valid */ put_le16(p + 54, s->cylinders); put_le16(p + 55, s->heads); put_le16(p + 56, s->sectors); @@ -437,6 +437,8 @@ put_le16(p + 85, (1 << 14)); put_le16(p + 86, 0); put_le16(p + 87, (1 << 14)); + put_le16(p + 88, 0x1f | (1 << 13)); + put_le16(p + 93, 1 | (1 << 14) | 0x2000 | 0x4000); } static void ide_atapi_identify(IDEState *s) @@ -1560,7 +1562,7 @@ case 0x82: /* write cache disable */ case 0xaa: /* read look-ahead enable */ case 0x55: /* read look-ahead disable */ - s->status = READY_STAT; + s->status = READY_STAT | SEEK_STAT; ide_set_irq(s); break; default: -- Jens Axboe