From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Sperling Date: Tue, 09 Nov 2004 23:16:46 +0000 Subject: Re: [KJ] [PATCH] convert airo wireless driver to module_param Message-Id: <20041109231646.GA11645@dice.seeling33.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============77937796980024698==" List-Id: References: <20041109212957.GA9496@dice.seeling33.de> In-Reply-To: <20041109212957.GA9496@dice.seeling33.de> To: kernel-janitors@vger.kernel.org --===============77937796980024698== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 09, 2004 at 02:28:15PM -0800, Randy.Dunlap wrote: > >>Rusty's first set of module_param() conversion patches, which > >>I mostly followed, use permission (last parameter) of 0 > >>(not visible in sysfs) except for fields that can be modified. > >>Often this is a "debug" or "verbose" flag or bitmask. > > > > > >Not in this one: > > > >http://marc.theaimsgroup.com/?l=linux-kernel&m=109826168201622&w=2 > > True. That's why we post patches and have review (one reason). > > >This is the reference link from the janitors TODO file. > >Everything 0444, except a debug flag, which is 0644. > > > >Can someone please clarify the "official guidelines" for > >module parameter permissions in sysfs? Shall I use 0 or 0444 > >for parameters that should not be modified, i.e. everything > >except debug and verbosity flags? > > Compare with Rusty's (other) conversion patch (with wrap): > > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1/2.6.10-rc1-mm2/broken-out/remove-module_parm-from-allyesconfig-almost.patch Yikes! He's quick. He's already converted some of the drivers I have been converting. Last time I looked he hadn't touched the wireless drivers yet... Well, at least he did not convert all of them yet... ;-) I'll post the missing ones soon so. stefan -- Give me a fish and I will eat today. Teach me to fish and I will eat forever. --===============77937796980024698== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============77937796980024698==--