From: Thomas Graf <tgraf@suug.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@oss.sgi.com
Subject: Re: request_module while holding rtnl semaphore
Date: Wed, 10 Nov 2004 02:39:41 +0100 [thread overview]
Message-ID: <20041110013941.GL31969@postel.suug.ch> (raw)
In-Reply-To: <41916F0B.5010809@trash.net>
* Patrick McHardy <41916F0B.5010809@trash.net> 2004-11-10 02:29
> Thomas Graf wrote:
> >The action code might load modules in the middle of a classifier
> >configuration and it will be very hard to reverse those changes.
> >Right now we could move it to the top of all configurations and it
> >would probably be possible to get back where we fetch the device
> >but it will get impossible once a classifier requires module
> >loading which is not unlikely.
> >
> >
> Assuming all error-paths do proper cleanup, returning -EAGAIN
> should always result in the same configuration state as before.
I agree but this assumption is wrong, at least for u32. I agree
that once this is true it would work perfectly fine, however I
think it would be inefficient to parse the whole TLV tree multiple
times.
next prev parent reply other threads:[~2004-11-10 1:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-04 3:11 request_module while holding rtnl semaphore Patrick McHardy
2004-11-05 23:35 ` Herbert Xu
2004-11-10 0:11 ` David S. Miller
2004-11-10 0:38 ` Patrick McHardy
2004-11-10 1:01 ` Thomas Graf
2004-11-10 1:10 ` Patrick McHardy
2004-11-10 1:22 ` Thomas Graf
2004-11-10 1:29 ` Patrick McHardy
2004-11-10 1:39 ` Thomas Graf [this message]
2004-11-10 1:41 ` Herbert Xu
2004-11-10 11:32 ` Thomas Graf
2004-11-10 11:42 ` Herbert Xu
2004-11-10 11:56 ` Thomas Graf
2004-11-10 1:47 ` Patrick McHardy
2004-12-12 17:57 ` Thomas Graf
2004-12-12 18:04 ` Patrick McHardy
2004-12-13 16:53 ` [RFC] tcf_bind_filter failure handling Thomas Graf
2004-12-13 18:11 ` Patrick McHardy
2004-12-13 18:52 ` Thomas Graf
2004-12-13 19:12 ` Patrick McHardy
2004-12-13 19:23 ` jamal
2004-12-13 19:32 ` Thomas Graf
2004-11-10 1:15 ` request_module while holding rtnl semaphore Herbert Xu
2005-01-11 3:04 ` Patrick McHardy
2005-01-11 9:47 ` Thomas Graf
2005-01-11 21:05 ` Patrick McHardy
2005-01-11 21:47 ` Thomas Graf
2005-01-11 21:50 ` Thomas Graf
2005-01-11 22:18 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041110013941.GL31969@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.