From: Andrew Morton <akpm@osdl.org>
To: Thomas Hood <jdthood@yahoo.co.uk>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] Documentation/preempt-locking.txt clarification
Date: Wed, 10 Nov 2004 01:45:43 -0800 [thread overview]
Message-ID: <20041110014543.143b8ff3.akpm@osdl.org> (raw)
In-Reply-To: <1100078840.3654.822.camel@thanatos>
Thomas Hood <jdthood@yahoo.co.uk> wrote:
>
> On Wed, 2004-11-10 at 09:57, Andrew Morton wrote:
> > I guess it's saying ...
>
> Thanks for the explanation. I include a new patch which incorporates
> your example. I am in no position to judge the _truth_ of the
> statements in this document; I am only hoping to _understand_ them. :)
I think the statement is in fact false. Ingo, what's your take on this
paragraph, from preempt-locking.txt?
An additional concern is proper usage of local_irq_disable and
local_irq_save. These may be used to protect from preemption, however,
on exit, if preemption may be enabled, a test to see if preemption is
required should be done. If these are called from the spin_lock and
read/write lock macros, the right thing is done. They may also be called
within a spin-lock protected region, however, if they are ever called
outside of this context, a test for preemption should be made. Do note
that calls from interrupt context or bottom half/ tasklets are also
protected by preemption locks and so may use the versions which do not
check preemption.
next prev parent reply other threads:[~2004-11-10 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1073302283.1903.85.camel@thanatos.hubertnet>
[not found] ` <1074561880.26456.26.camel@localhost>
2004-11-10 8:21 ` [PATCH] Documentation/preempt-locking.txt clarification Thomas Hood
2004-11-10 8:57 ` Andrew Morton
2004-11-10 9:27 ` Thomas Hood
2004-11-10 9:45 ` Andrew Morton [this message]
2004-11-10 10:59 ` Ingo Molnar
2004-11-10 11:03 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041110014543.143b8ff3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jdthood@yahoo.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.