All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: ncunningham@linuxmail.org, wli@holomorphy.com,
	linux-kernel@vger.kernel.org
Subject: Re: Broken kunmap calls in rc4-mm1.
Date: Thu, 11 Nov 2004 08:45:10 +0100	[thread overview]
Message-ID: <20041111074509.GD9129@suse.de> (raw)
In-Reply-To: <20041110185925.1c2eb9bf.akpm@osdl.org>

On Wed, Nov 10 2004, Andrew Morton wrote:
> Nigel Cunningham <ncunningham@linuxmail.org> wrote:
> >
> > Remaining culprits are....
> > 
> >  Reiser4:
> >  - do_readpage_tail
> >   -reiser4_status_init
> >   -reiser4_status_write
> 
> obuggerit.  Look, a simple helper is to redefine kmap_atomic() and
> kunmap_atomic() to work on char*'s.  This will spit warnings if someone
> feeds in a page*.  Which would be a lot more useful if we didn't have all
> those infernal __iomem warnings scrolling off the screen but ho hum.

I tried something like this, but got stuck on people passing a structure
in which is valid (aio_setup_ring(), for instance). We can always cast
those of course, but it's not so pretty.

-- 
Jens Axboe


  reply	other threads:[~2004-11-11  7:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-11  1:17 Broken kunmap calls in rc4-mm1 Nigel Cunningham
2004-11-11  1:29 ` William Lee Irwin III
2004-11-11  1:42   ` Nigel Cunningham
2004-11-11  2:59     ` Andrew Morton
2004-11-11  7:45       ` Jens Axboe [this message]
2004-11-11  7:50         ` Andrew Morton
2004-11-11 19:22   ` Pavel Machek
2004-11-11  1:34 ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041111074509.GD9129@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@linuxmail.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.