Re: [PATCH] MASQUERADE handling of device events

["David S. Miller" <davem@davemloft.net>]

On Mon, 8 Nov 2004 14:50:25 +0100
Harald Welte <laforge@netfilter.org> wrote:

> Dave: would the two changes below be acceptable for you?
> 
> > 1) export inet_confirm_addr

This one I think is OK.

> > 2) change inet_ifa_match to use ifa_local instead of ifa_address.
> >    Since ifa_local != ifa_address on ppp interfaces, inet_ifa_match
> >    could not be used to verify ppp interface addresses without
> >    this change.

This one on the other hand is a serious semantic change
and needs more careful thought.  ifa_address is used for
a reason, and people expecting that are going to break
if we change things this way.

A study of at least the net/ipv4/devinet.c shows that this
ifa_address vs. ifa_local distinction is definitely on
purpose.  I really don't think we can make this suggested
change therefore.