From: Christoph Hellwig <hch@infradead.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Michael Heyse <mhk@designassembly.de>,
Mirko Lindner <mlindner@syskonnect.de>,
netdev@oss.sgi.com
Subject: Re: [PATCH] (15/23) sk98: rearrange initialization
Date: Fri, 12 Nov 2004 16:30:41 +0000 [thread overview]
Message-ID: <20041112163041.GC7066@infradead.org> (raw)
In-Reply-To: <20041111160113.15a356cd@zqx3.pdx.osdl.net>
On Thu, Nov 11, 2004 at 04:01:13PM -0800, Stephen Hemminger wrote:
> The code in the latest SysKonnect driver is arranged differently,
> this aligns the two versions to allow for easier comparisons.
> Also:
> Don't enable the pci device twice.
> Add common SkGeDevInit for common code used to setup both ports
please don't reorder the functions. I placed them in natural order when
converting to new pci probing for a good reason.
next prev parent reply other threads:[~2004-11-12 16:30 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 1:53 new sk98lin driver Michael Heyse
2004-11-11 2:46 ` Jeff Garzik
2004-11-11 19:05 ` Michael Heyse
[not found] ` <20041111154225.5cf85567@zqx3.pdx.osdl.net>
2004-11-11 23:53 ` [PATCH] (2/23) sk98: local variable can be constant Stephen Hemminger
2004-11-11 23:53 ` [PATCH] (3/23) sk98: /proc interface related changes Stephen Hemminger
2004-11-12 16:26 ` Christoph Hellwig
2004-11-13 4:34 ` shemminger
2004-11-11 23:54 ` [PATCH] (4/23) sk98: use netdev_priv Stephen Hemminger
2004-11-11 23:54 ` [PATCH] (5/23) sk98: use module_param Stephen Hemminger
2004-11-11 23:54 ` [PATCH] (6/23) sk98: add netpoll console support Stephen Hemminger
2004-11-11 23:55 ` [PATCH] (7/23) sk98: basic ethtool support Stephen Hemminger
2004-11-12 16:29 ` Christoph Hellwig
2004-11-13 4:39 ` shemminger
2004-11-11 23:55 ` [PATCH] (8/23) sk98: ethtool phy support Stephen Hemminger
2004-11-11 23:55 ` [PATCH] (9/23) sk98: ethtool pause param support Stephen Hemminger
2004-11-11 23:55 ` [PATCH] (10/23) sk98: cleanout unnecessary controller elements Stephen Hemminger
2004-11-14 1:43 ` Jeff Garzik
2004-11-11 23:57 ` [PATCH] (12/23) sk98: add module version Stephen Hemminger
2004-11-11 23:57 ` [PATCH] (11/23) sk98: board counter incremented twice Stephen Hemminger
2004-11-12 0:00 ` [PATCH] (13/23) sk98: handle ring full correctly Stephen Hemminger
2004-11-12 10:54 ` Tommy Christensen
2004-11-12 0:01 ` [PATCH] (15/23) sk98: rearrange initialization Stephen Hemminger
2004-11-12 16:30 ` Christoph Hellwig [this message]
2004-11-13 4:43 ` shemminger
2004-11-12 0:01 ` [PATCH] (14/23) sk98: don't obfuscate irqreturn_t Stephen Hemminger
2004-11-12 0:02 ` [PATCH] (16/23) sk98: more efficient time OsGetTime Stephen Hemminger
2004-11-12 0:03 ` [PATCH] (17/23) sk98: use lockless transmit Stephen Hemminger
2004-11-12 0:07 ` [PATCH] (20/23) sk98: checksum ethtool and improvements Stephen Hemminger
2004-11-12 0:07 ` [PATCH] (19/23) sk98: more cleanups Stephen Hemminger
2004-11-12 0:07 ` [PATCH] (18/23) sk98: update pci_id table Stephen Hemminger
2004-11-12 0:09 ` [PATCH] (21/23) sk98: transmit ring barriers Stephen Hemminger
2004-11-12 0:09 ` [PATCH] (22/23) sk98: diag code changes Stephen Hemminger
2004-11-12 0:11 ` [PATCH] (23/23) sk98: eliminate large controller scratch pad elements Stephen Hemminger
2004-11-12 0:11 ` [PATCH] (0/23) sk98 driver fixes and enhancements Stephen Hemminger
2004-11-12 0:17 ` Michael Heyse
2004-11-12 0:27 ` Stephen Hemminger
[not found] ` <20041111154016.6381189d@zqx3.pdx.osdl.net>
2004-11-12 0:11 ` [PATCH] (1/23) sk98: no explicit module ref counting needed Stephen Hemminger
2004-11-12 0:51 ` Mirko Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041112163041.GC7066@infradead.org \
--to=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=mhk@designassembly.de \
--cc=mlindner@syskonnect.de \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.