All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Thomas Schlichter <thomas.schlichter@web.de>,
	linux-kernel@vger.kernel.org,
	Zwane Mwaikambo <zwane@holomorphy.com>
Subject: Re: 2.6.10-rc1-mm4
Date: 13 Nov 2004 00:11:26 +0100
Date: Sat, 13 Nov 2004 00:11:26 +0100	[thread overview]
Message-ID: <20041112231126.GC15853@muc.de> (raw)
In-Reply-To: <20041110150307.3a06cc1d.akpm@osdl.org>

> > kernel BUG at arch/i386/mm/highmem.c:63!
> > EIP is at kunmap_atomic+0x27/0x70
> > Call Trace
> >   show_stack+0xa6/0xb0
> >   show_register+0x14d/0x1c0
> >   die+0x158/0x2e0
> >   do_invalid_op+0xef/0x100
> >   error_code+0x2b/0x30
> >   copy_pte_range+0x122/0x490
> 
> This might help:

Indeed. Thanks for fixing this.  I checked the other functions,
but it seems I only made this mistake once.

-Andi

> 
> 
> 
> 
> We're modifying src_pte and dst_pte in the for-loop, and then unmapping the
> modified pointers.  If one of them walked off the end of the page then blam.
> 
> 
> Signed-off-by: Andrew Morton <akpm@osdl.org>

  reply	other threads:[~2004-11-12 23:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-10 22:33 2.6.10-rc1-mm4 Thomas Schlichter
2004-11-10 23:03 ` 2.6.10-rc1-mm4 Andrew Morton
2004-11-12 23:11   ` Andi Kleen [this message]
2004-11-12 23:31   ` 2.6.10-rc1-mm4 Zwane Mwaikambo
  -- strict thread matches above, loose matches on Subject: below --
2004-11-09 15:49 2.6.10-rc1-mm4 Andrew Morton
2004-11-09 16:11 ` 2.6.10-rc1-mm4 Jens Axboe
2004-11-09 19:53   ` 2.6.10-rc1-mm4 Andrew Morton
2004-11-09 21:14     ` 2.6.10-rc1-mm4 Jens Axboe
2004-11-09 21:57       ` 2.6.10-rc1-mm4 Jens Axboe
2004-11-10 16:28       ` 2.6.10-rc1-mm4 Jens Axboe
2004-11-09 16:32 ` 2.6.10-rc1-mm4 Jesse Barnes
2004-11-09 16:41 ` 2.6.10-rc1-mm4 Markus Trippelsdorf
2004-11-09 17:02 ` 2.6.10-rc1-mm4 Stefano Rivoir
2004-11-09 23:18   ` 2.6.10-rc1-mm4 Dave Airlie
2004-11-10  1:30     ` 2.6.10-rc1-mm4 Dave Airlie
2004-11-10  7:44     ` 2.6.10-rc1-mm4 Stefano Rivoir
2004-11-11  7:39     ` 2.6.10-rc1-mm4 Stefano Rivoir
2004-11-10 11:40 ` 2.6.10-rc1-mm4 Fabio Coatti
2004-11-10 12:36   ` 2.6.10-rc1-mm4 Rafael J. Wysocki
2004-11-11 10:17 ` 2.6.10-rc1-mm4 Stefano Rivoir
2004-11-11 10:24   ` 2.6.10-rc1-mm4 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041112231126.GC15853@muc.de \
    --to=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.schlichter@web.de \
    --cc=zwane@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.