All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	Harald Welte <laforge@gnumonks.org>,
	"David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
	patrick@tykepenguin.com, linux-decnet-user@lists.sourceforge.net
Subject: [patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed
Date: Sat, 13 Nov 2004 21:07:35 +0100	[thread overview]
Message-ID: <20041113200735.GD2249@stusta.de> (raw)
In-Reply-To: <20041112180052.GE23215@logos.cnet>

I'm getting the following error:

<--  snip  -->

depmod: *** Unresolved symbols in /lib/modules/2.4.28-rc3/kernel/net/decnet/decnet.o
depmod:         neigh_for_each

<--  snip  -->


This was caused by Harald's backport of the neighbour scalability fixes 
from 2.6 .


neigh_for_each must be EXPORT_SYMBOL'ed (as it is in 2.6):


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.4.28-rc3-modular/net/core/Makefile.old	2004-11-13 19:40:36.000000000 +0100
+++ linux-2.4.28-rc3-modular/net/core/Makefile	2004-11-13 19:40:50.000000000 +0100
@@ -9,7 +9,7 @@
 
 O_TARGET := core.o
 
-export-objs := netfilter.o profile.o ethtool.o
+export-objs := netfilter.o profile.o ethtool.o neighbour.o
 
 obj-y := sock.o skbuff.o iovec.o datagram.o scm.o
 
--- linux-2.4.28-rc3-modular/net/core/neighbour.c.old	2004-11-13 19:35:26.000000000 +0100
+++ linux-2.4.28-rc3-modular/net/core/neighbour.c	2004-11-13 19:35:59.000000000 +0100
@@ -1569,6 +1569,7 @@
 	}
 	read_unlock_bh(&tbl->lock);
 }
+EXPORT_SYMBOL(neigh_for_each);
 
 /* The tbl->lock must be held as a writer and BH disabled. */
 void __neigh_for_each_release(struct neigh_table *tbl,



  parent reply	other threads:[~2004-11-13 20:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-12 18:00 Linux 2.4.28-rc3 Marcelo Tosatti
2004-11-13 16:27 ` Andrey Melnikoff
2004-11-13 15:24   ` Marcelo Tosatti
2005-01-19 17:50     ` megaraid2.c PATCH (was: Linux 2.4.28-rc3) Andrey J. Melnikoff (TEMHOTA)
2005-01-19 15:56       ` Marcelo Tosatti
2004-11-13 20:07 ` Adrian Bunk [this message]
2004-11-14  7:25   ` [patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed David S. Miller
2004-11-14 10:35 ` Linux 2.4.28-rc3 Willy Tarreau
  -- strict thread matches above, loose matches on Subject: below --
2004-11-15 15:27 [patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed O.Sezer
2004-11-15 23:17 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041113200735.GD2249@stusta.de \
    --to=bunk@stusta.de \
    --cc=davem@davemloft.net \
    --cc=laforge@gnumonks.org \
    --cc=linux-decnet-user@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=netdev@oss.sgi.com \
    --cc=patrick@tykepenguin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.