From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [BK PATCH] More Driver Core patches for 2.6.10-rc1
Date: Sat, 13 Nov 2004 13:10:38 -0800 [thread overview]
Message-ID: <20041113211038.GA7060@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0411131249340.12386@ppc970.osdl.org>
On Sat, Nov 13, 2004 at 12:51:41PM -0800, Linus Torvalds wrote:
>
>
> On Fri, 12 Nov 2004, Greg KH wrote:
> >
> > David Brownell:
> > o driver core: shrink struct device a bit
> >
> > Greg Kroah-Hartman:
> > o driver core: fix up some missed power_state changes from David's patch
>
> Hmm. Apparently drivers/ide/ppc/pmac.c wasn't among those fixed up:
>
> drivers/ide/ppc/pmac.c: In function `pmac_ide_macio_suspend':
> drivers/ide/ppc/pmac.c:1363: error: structure has no member named `power_state'
> drivers/ide/ppc/pmac.c:1366: error: structure has no member named `power_state'
> ...
Oops, sorry about that.
> Is it always valid to just replace
>
> dev->dev.power_state
>
> with
>
> dev->dev.power.power_state
Yes it is.
> or is there anything subtler going on?
Nope, nothing subtle here :)
thanks,
greg k-h
next prev parent reply other threads:[~2004-11-13 21:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-12 22:58 [BK PATCH] More Driver Core patches for 2.6.10-rc1 Greg KH
2004-11-12 23:00 ` [PATCH] " Greg KH
2004-11-12 23:00 ` Greg KH
2004-11-12 23:00 ` Greg KH
2004-11-12 23:00 ` Greg KH
2004-11-12 23:00 ` Greg KH
2004-11-12 23:00 ` Greg KH
2004-11-12 23:00 ` Greg KH
2004-11-12 23:00 ` Greg KH
2004-11-12 23:00 ` Greg KH
[not found] ` <20041113000052.GC346@electric-eye.fr.zoreil.com>
[not found] ` <200411130020.17494.lists@kenneth.aafloy.net>
2004-11-13 0:44 ` Greg KH
2004-11-13 20:51 ` [BK PATCH] " Linus Torvalds
2004-11-13 21:10 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-11-05 0:47 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041113211038.GA7060@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.