All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: davem@redhat.com
Cc: netdev@oss.sgi.com
Subject: [PATCH] use local_softirq_pending instead of softirq_pending in netif_rx_ni
Date: Sun, 14 Nov 2004 11:38:46 +0100	[thread overview]
Message-ID: <20041114103846.GA32024@lst.de> (raw)

Some architectures can optimize local_softirq_pending much better than
softirq_pending(smp_processor_id()), and for all others the former is
just a macro expanding to the later.

Also this is the last use of softirq_pending() in common code, once this
is in we can soon kill the notation of beeing able to query other cpus
softirq pending count.


--- 1.174/net/core/dev.c	2004-11-10 01:12:00 +01:00
+++ edited/net/core/dev.c	2004-11-14 11:35:19 +01:00
@@ -1470,7 +1470,7 @@ int netif_rx_ni(struct sk_buff *skb)
 
 	preempt_disable();
 	err = netif_rx(skb);
-	if (softirq_pending(smp_processor_id()))
+	if (local_softirq_pending())
 		do_softirq();
 	preempt_enable();
 

             reply	other threads:[~2004-11-14 10:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-14 10:38 Christoph Hellwig [this message]
2004-11-18 22:22 ` [PATCH] use local_softirq_pending instead of softirq_pending in netif_rx_ni David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041114103846.GA32024@lst.de \
    --to=hch@lst.de \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.