All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: mikael.starvik@axis.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] remove bogus double softirq processing in cris
Date: Sun, 14 Nov 2004 11:43:28 +0100	[thread overview]
Message-ID: <20041114104327.GA32182@lst.de> (raw)

I sent this out long ago already, but it's still not in:

  These days irq_exit does all softirq processing, so there's no need to
  call do_softirq again in cris.

Also is there any chance you could switch cris to use the new
CONFIG_GENERIC_HARDIRQS code in 2.6.10-rc that would replace most of
arch/cris/kernel/irq.c with generic code from kernel/irq/* ?


--- 1.17/arch/cris/kernel/irq.c	2004-10-20 10:37:14 +02:00
+++ edited/arch/cris/kernel/irq.c	2004-11-14 11:39:14 +01:00
@@ -158,11 +158,6 @@ asmlinkage void do_IRQ(int irq, struct p
 		local_irq_disable();
         }
         irq_exit();
-
-	if (softirq_pending(cpu))
-                do_softirq();
-
-        /* unmasking and bottom half handling is done magically for us. */
 }
 
 /* this function links in a handler into the chain of handlers for the

             reply	other threads:[~2004-11-14 10:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-14 10:43 Christoph Hellwig [this message]
2005-01-03 13:27 ` [PATCH] remove bogus double softirq processing in cris Christoph Hellwig
     [not found] <BFECAF9E178F144FAEF2BF4CE739C66802055E59@exmail1.se.axis.com>
2005-01-03 13:34 ` Mikael Starvik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041114104327.GA32182@lst.de \
    --to=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikael.starvik@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.