From: Christoph Hellwig <hch@lst.de>
To: rmk@arm.linux.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] kill unused call_irq()
Date: Sun, 14 Nov 2004 11:46:27 +0100 [thread overview]
Message-ID: <20041114104627.GA32234@lst.de> (raw)
These routine in arm and arm26 is unused (in fact not even compiled).
Inatead of converting it to local_softirq_pending I'd suggest just
removing it as below as it's been there totally unused for a long time.
Inatead of converting it to local_softirq_pending I'd suggest just
removing it as below as it's been there totally unused for a long time.
--- 1.8/include/asm-arm/mach/irq.h 2003-08-05 21:35:12 +02:00
+++ edited/include/asm-arm/mach/irq.h 2004-11-14 11:48:41 +01:00
@@ -97,23 +97,6 @@ void __set_irq_handler(unsigned int irq,
void set_irq_chip(unsigned int irq, struct irqchip *);
void set_irq_flags(unsigned int irq, unsigned int flags);
-#ifdef not_yet
-/*
- * This is to be used by the top-level machine IRQ decoder only.
- */
-static inline void call_irq(struct pt_regs *regs, unsigned int irq)
-{
- struct irqdesc *desc = irq_desc + irq;
-
- spin_lock(&irq_controller_lock);
- desc->handle(irq, desc, regs);
- spin_unlock(&irq_controller_lock);
-
- if (softirq_pending(smp_processor_id()))
- do_softirq();
-}
-#endif
-
#define IRQF_VALID (1 << 0)
#define IRQF_PROBE (1 << 1)
#define IRQF_NOAUTOEN (1 << 2)
--- 1.1/include/asm-arm26/irqchip.h 2003-06-04 13:14:10 +02:00
+++ edited/include/asm-arm26/irqchip.h 2004-11-14 11:48:53 +01:00
@@ -85,23 +85,6 @@ void __set_irq_handler(unsigned int irq,
void set_irq_chip(unsigned int irq, struct irqchip *);
void set_irq_flags(unsigned int irq, unsigned int flags);
-#ifdef not_yet
-/*
- * This is to be used by the top-level machine IRQ decoder only.
- */
-static inline void call_irq(struct pt_regs *regs, unsigned int irq)
-{
- struct irqdesc *desc = irq_desc + irq;
-
- spin_lock(&irq_controller_lock);
- desc->handle(irq, desc, regs);
- spin_unlock(&irq_controller_lock);
-
- if (softirq_pending(smp_processor_id()))
- do_softirq();
-}
-#endif
-
#define IRQF_VALID (1 << 0)
#define IRQF_PROBE (1 << 1)
#define IRQF_NOAUTOEN (1 << 2)
next reply other threads:[~2004-11-14 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-14 10:46 Christoph Hellwig [this message]
2004-11-20 17:35 ` [PATCH] kill unused call_irq() Russell King
2004-11-27 0:34 ` Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041114104627.GA32234@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.