All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] PCI cleanups
Date: Mon, 15 Nov 2004 11:51:48 -0800	[thread overview]
Message-ID: <20041115195148.GA12820@kroah.com> (raw)
In-Reply-To: <20041113030203.GU2249@stusta.de>

On Sat, Nov 13, 2004 at 04:02:03AM +0100, Adrian Bunk wrote:
> The patch below does some cleanups in the PCI code:
> - make OSC_UUID in drivers/pci/pci-acpi.c static
> - remove the completely unused drivers/pci/hotplug/pciehp_sysfs.c
> - remove other unused code
> 
> Please review which of these changes are correct and which conflict with 
> pending changes.
> 

>  drivers/pci/hotplug/Makefile       |    1 
>  drivers/pci/hotplug/pciehp.h       |    3 
>  drivers/pci/hotplug/pciehp_sysfs.c |  143 -------------

Yeah, this can be deleted.  Care to make a patch for just this?

>  drivers/pci/msi.c                  |  301 -----------------------------
>  drivers/pci/msi.h                  |    1 

These changes are for when drivers want to start taking advantage of
some MSI features.  I've heard rumors that those drivers will be public
soon, but haven't seen them yet :(

>  drivers/pci/pci-acpi.c             |   97 ---------

This is needed for some upcoming PCI Express changes, and should not be
dropped.  I've seen the code that needs this, but it is still under
development and isn't ready for mainline yet.

>  drivers/pci/pci.c                  |   60 -----
>  drivers/pci/rom.c                  |   52 -----

These changes are needed by upcoming video driver changes.

thanks,

greg k-h

  reply	other threads:[~2004-11-15 19:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-13  3:02 [2.6 patch] PCI cleanups Adrian Bunk
2004-11-15 19:51 ` Greg KH [this message]
2004-11-15 20:30   ` Roland Dreier
2004-11-15 23:01   ` [2.6 patch] remove unused drivers/pci/hotplug/pciehp_sysfs.c Adrian Bunk
2004-11-19 18:30     ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2004-11-15 19:41 [2.6 patch] PCI cleanups Nguyen, Tom L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041115195148.GA12820@kroah.com \
    --to=greg@kroah.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.