From: Christoph Hellwig <hch@infradead.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Mirko Lindner <demon@pro-linux.de>,
netdev@oss.sgi.com
Subject: Re: [PATCH] (4/25) sk98: change #define to typedef
Date: Tue, 16 Nov 2004 08:22:54 +0000 [thread overview]
Message-ID: <20041116082254.GA24321@infradead.org> (raw)
In-Reply-To: <20041115152203.24adb0ea@zqx3.pdx.osdl.net>
On Mon, Nov 15, 2004 at 03:22:03PM -0800, Stephen Hemminger wrote:
> Change #define of to a typedef.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>
> diff -Nru a/drivers/net/sk98lin/h/skdrv1st.h b/drivers/net/sk98lin/h/skdrv1st.h
> --- a/drivers/net/sk98lin/h/skdrv1st.h 2004-11-15 11:22:28 -08:00
> +++ b/drivers/net/sk98lin/h/skdrv1st.h 2004-11-15 11:22:28 -08:00
> @@ -106,7 +106,7 @@
> #define SK_MAX_MACS 2
> #define SK_MAX_NETS 2
>
> -#define SK_IOC char __iomem *
> +typedef void __iomem *SK_IOC;
Why do you need the typedef at all? Just about every driver on the
planet is fine with a single void *__iomem iobase; in the per-device
structure
next prev parent reply other threads:[~2004-11-16 8:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041115150910.0f3b8498@zqx3.pdx.osdl.net>
2004-11-15 23:21 ` [PATCH] (2/25) sk98: handle device rename impact on /proc Stephen Hemminger
2004-11-15 23:21 ` [PATCH] (3/25) sk98: remove #define of net_device Stephen Hemminger
2004-11-15 23:22 ` [PATCH] (4/25) sk98: change #define to typedef Stephen Hemminger
2004-11-16 8:22 ` Christoph Hellwig [this message]
2004-11-15 23:22 ` [PATCH] (5/25) sk98: elimnate nested macro Stephen Hemminger
2004-11-16 8:23 ` Christoph Hellwig
2004-11-15 23:22 ` [PATCH] (6/25) sk98: get rid of #define's for C99 types Stephen Hemminger
2004-11-15 23:23 ` [PATCH] (7/25) sk98: remove unneeded include's Stephen Hemminger
2004-11-16 15:56 [PATCH] (4/25) sk98: change #define to typedef Mirko Lindner
2004-11-16 17:12 ` Stephen Hemminger
2004-11-17 15:01 ` Christoph Hellwig
2004-11-19 0:23 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041116082254.GA24321@infradead.org \
--to=hch@infradead.org \
--cc=demon@pro-linux.de \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.