From: stefan@binarchy.net
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] MODULE_PARM in drivers/net/ppp_async.c
Date: Tue, 16 Nov 2004 08:34:07 +0000 [thread overview]
Message-ID: <20041116083407.GA23559@stud.seeling33.de> (raw)
In-Reply-To: <20041115203611.GA6214@voyager>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Mon, Nov 15, 2004 at 09:36:11PM +0100, Carlo Perassi wrote:
> Hi.
> Compiling 2.6.10-rc2 with ppp_async.ko I saw a warning about
> MODULE_PARAM.
> I do not know a lot on this topic, anyway I searched a bit about that
> and tried to patch the ppp_async.c file.
> I compiled (without getting the previous warning) and tested ppp with
> the attached patch.
> Please let me know if it is the proper way to patch it.
> --- linux-2.6.10-rc2-orig/drivers/net/ppp_async.c 2004-11-15 21:22:04.000000000 +0100
> +++ linux-2.6.10-rc2-mod/drivers/net/ppp_async.c 2004-11-15 21:21:47.000000000 +0100
> @@ -84,7 +84,7 @@ struct asyncppp {
> #define SC_RCV_BITS (SC_RCV_B7_1|SC_RCV_B7_0|SC_RCV_ODDP|SC_RCV_EVNP)
>
> static int flag_time = HZ;
> -MODULE_PARM(flag_time, "i");
> +module_param(flag_time, int, 0444);
> MODULE_PARM_DESC(flag_time, "ppp_async: interval between flagged packets (in clock ticks)");
> MODULE_LICENSE("GPL");
> MODULE_ALIAS_LDISC(N_PPP);
Looks good to me.
stefan
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-11-16 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-15 20:36 [KJ] [PATCH] MODULE_PARM in drivers/net/ppp_async.c Carlo Perassi
2004-11-16 8:34 ` stefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041116083407.GA23559@stud.seeling33.de \
--to=stefan@binarchy.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.