From: Martin Habets <errandir_news@mph.eclipse.co.uk>
To: linux-ide@vger.kernel.org
Subject: Re: WIN_READ_NATIVE_MAX_EXT returns incomplete result
Date: Wed, 17 Nov 2004 15:41:27 +0000 [thread overview]
Message-ID: <20041117154126.GA16688@palantir8> (raw)
In-Reply-To: <58cb370e04111610291be130b4@mail.gmail.com>
On Tue, Nov 16, 2004 at 07:29:31PM +0100, Bartlomiej Zolnierkiewicz wrote:
> In kernel 2.6.8 LBA48 support is disabled for ALi chipsets with revisions
> <= 0xC4 (drive->addressing is set to zero) but idedisk_check_hpa()
> incorrectly uses drive->id directly which results in this bug (because
> do_rw_taskfile() and ide_end_drive_cmd() rely on drive->addressing).
>
> This patch should fix it:
Thanks, works like a charm!
> --- ide-disk.c.orig 2004-11-05 23:24:41.000000000 +0100
> +++ ide-disk.c 2004-11-16 19:24:17.321273832 +0100
> @@ -625,7 +625,7 @@
> static inline void idedisk_check_hpa(ide_drive_t *drive)
> {
> unsigned long long capacity, set_max;
> - int lba48 = idedisk_supports_lba48(drive->id);
> + unsigned int lba48 = drive->addressing;
>
> capacity = drive->capacity64;
> if (lba48)
>
> Moreover you shouldn't hit this bug in current kernels because they
> use LBA48 (with some limitations: no DMA for LBA48 area) for ALi
> chipsets revs <= 0xC4.
Was planning to stay on 2.6.8 for a while.
--
Martin
prev parent reply other threads:[~2004-11-17 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 17:34 WIN_READ_NATIVE_MAX_EXT returns incomplete result Martin Habets
2004-11-16 18:29 ` Bartlomiej Zolnierkiewicz
2004-11-17 15:41 ` Martin Habets [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041117154126.GA16688@palantir8 \
--to=errandir_news@mph.eclipse.co.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.