From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: cliff white <cliffw@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.10-rc1-mm5 - badness in enable_irg, BUG
Date: Thu, 18 Nov 2004 10:52:53 +0100 [thread overview]
Message-ID: <20041118095253.GA16054@elte.hu> (raw)
In-Reply-To: <20041117210219.43a36302.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> > BUG: using smp_processor_id() in preemptible [00000001] code: mkdir/11768
> > caller is munmap_notify+0x7b/0x90 [oprofile]
> > [<c020a465>] smp_processor_id+0xb5/0xc0
> > [<f8912a4b>] munmap_notify+0x7b/0x90 [oprofile]
> > [<f8912a4b>] munmap_notify+0x7b/0x90 [oprofile]
> > [<c012b55d>] notifier_call_chain+0x2d/0x50
> > [<c011dd93>] profile_munmap+0x33/0x50
> > [<c01536f7>] sys_munmap+0x27/0x80
> > [<c01046d3>] syscall_call+0x7/0xb
>
> ho hum, I guess we should suppress these oprofile warnings somehow.
>
> Ingo, is there an smp_processor_id() variant which bypasses the warning?
yeah, just use _smp_processor_id() for the checking-less variant.
> btw, this:
> is insane. Any chance of simplifying it all?
since usually there are lots of arch-level false positives it didnt seem
prudent to enable the warning unconditionally for every arch. So an arch
can enable it right now by changing its smp_processor_id definition to
__smp_processor_id - and the #ifdefs will do their job to adapt. Once
most architectures have this enabled (right now only x86 and x64 have
it) we could simplify it down by making it unconditional but right now i
dont think it's a good idea.
Ingo
next prev parent reply other threads:[~2004-11-18 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-15 17:37 2.6.10-rc1-mm5 - badness in enable_irg, BUG cliff white
2004-11-15 17:49 ` cliff white
2004-11-18 5:02 ` Andrew Morton
2004-11-18 9:52 ` Ingo Molnar [this message]
2004-11-18 9:15 ` Andrew Morton
2004-11-18 10:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041118095253.GA16054@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=cliffw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.