From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.33)
	id 1CUiiU-0004xJ-Eo
	for mharc-grub-devel@gnu.org; Thu, 18 Nov 2004 04:36:38 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1CUiiP-0004vD-BG
	for grub-devel@gnu.org; Thu, 18 Nov 2004 04:36:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1CUiiM-0004u6-8r
	for grub-devel@gnu.org; Thu, 18 Nov 2004 04:36:31 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1CUiiL-0004u2-BO
	for grub-devel@gnu.org; Thu, 18 Nov 2004 04:36:29 -0500
Received: from [212.43.237.68] (helo=kotoba.storever.com)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1CUiZT-0005K5-PB
	for grub-devel@gnu.org; Thu, 18 Nov 2004 04:27:19 -0500
Received: from localhost (localhost [127.0.0.1])
	by kotoba.storever.com (Postfix) with ESMTP id EC80BF8AC90A
	for <grub-devel@gnu.org>; Thu, 18 Nov 2004 10:27:17 +0100 (CET)
From: "Yoshinori K. Okuji" <okuji@enbug.org>
Organization: enbug.org
To: The development of GRUB 2 <grub-devel@gnu.org>
Date: Thu, 18 Nov 2004 10:28:49 +0100
User-Agent: KMail/1.6.1
References: <87actg8ehq.fsf@marco.marco-g.com>
In-Reply-To: <87actg8ehq.fsf@marco.marco-g.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200411181028.50091.okuji@enbug.org>
Subject: Re: Partition modules
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Nov 2004 09:36:35 -0000

On Wednesday 17 November 2004 20:25, Marco Gerards wrote:
> Can someone please this patch on the PC for me to see if it works?  I
> don't know when I can do that, I just tried if it compiles correctly
> on the PC.

Don't expect me to test it... I might be able to have time in this 
weekend, but no guarantee.

> Index: include/grub/pc_partition.h
> ===================================================================
> RCS file: include/grub/pc_partition.h
> diff -N include/grub/pc_partition.h
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ include/grub/pc_partition.h	17 Nov 2004 19:12:22 -0000
> @@ -0,0 +1,190 @@
[snip]

The macros defined in this header should use different names, because 
GRUB_PARTITION_FOO is too generic. Maybe GRUB_PC_PARTITION_FOO?

The other parts look good for me.

Thanks,
Okuji