From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1CUile-0006Ap-8f for mharc-grub-devel@gnu.org; Thu, 18 Nov 2004 04:39:54 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CUilb-0006Ah-Pk for grub-devel@gnu.org; Thu, 18 Nov 2004 04:39:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CUilZ-0006AJ-Te for grub-devel@gnu.org; Thu, 18 Nov 2004 04:39:50 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUilZ-0006AG-Fk for grub-devel@gnu.org; Thu, 18 Nov 2004 04:39:49 -0500 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CUicg-0005q7-8m for grub-devel@gnu.org; Thu, 18 Nov 2004 04:30:38 -0500 Received: from localhost (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id CC98FF8AC90A for ; Thu, 18 Nov 2004 10:30:37 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Thu, 18 Nov 2004 10:32:10 +0100 User-Agent: KMail/1.6.1 References: <87actg8ehq.fsf@marco.marco-g.com> In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200411181032.10290.okuji@enbug.org> Subject: Re: Partition modules X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2004 09:39:52 -0000 On Thursday 18 November 2004 04:50, Hollis Blanchard wrote: > I do have an objection here: members like "bsd_type" don't belong in > a generic struct, but rather in grub_partition_bsd_type. I believe > grub_partition should be the abstraction, i.e. what defines a > partition in the general sense. start, len, and index are obviously > good; offset is compensating for a DOS issue, though at least it has > (irrelevant) meaning for an Apple map... but ext_offset and these > dos_ and bsd_ things don't belong here IMHO. I agree with you in theory... but I guess it is a bit difficult to make BSD disklabel independent, because it is sometimes used alone and it is sometimes nested in other partition types. I hope Marco will find out a good solution here. Okuji