From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262929AbUKRTft (ORCPT ); Thu, 18 Nov 2004 14:35:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262925AbUKRTeF (ORCPT ); Thu, 18 Nov 2004 14:34:05 -0500 Received: from ra.tuxdriver.com ([24.172.12.4]:62728 "EHLO ra.tuxdriver.com") by vger.kernel.org with ESMTP id S262920AbUKRTbb (ORCPT ); Thu, 18 Nov 2004 14:31:31 -0500 Date: Thu, 18 Nov 2004 14:27:49 -0500 From: "John W. Linville" To: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org, netdev@oss.sgi.com Cc: greearb@candelatech.com, jgarzik@pobox.com Subject: [patch netdev-2.4] vlan_dev: return 0 on vlan_dev_change_mtu success Message-ID: <20041118142749.C16007@tuxdriver.com> Mail-Followup-To: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org, netdev@oss.sgi.com, greearb@candelatech.com, jgarzik@pobox.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org The VLAN net driver needs to return 0 from vlan_dev_change_mtu() on success. Signed-off-by: John W. Linville --- The proper sucessful return code for the change_mtu() method is zero. For some reason, vlan_dev_change_mtu() is returning the new mtu value instead. net/8021q/vlan_dev.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) --- 1.14/net/8021q/vlan_dev.c 2004-07-05 19:34:03 -04:00 +++ edited/net/8021q/vlan_dev.c 2004-11-18 14:26:29 -05:00 @@ -528,7 +528,7 @@ dev->mtu = new_mtu; - return new_mtu; + return 0; } int vlan_dev_set_ingress_priority(char *dev_name, __u32 skb_prio, short vlan_prio)