Re: [PATCH] LLDD dynamic scan aids

[Patrick Mansfield <patmans@us.ibm.com>]

On Thu, Nov 18, 2004 at 02:36:44PM +0000, Christoph Hellwig wrote:
> On Thu, Nov 18, 2004 at 09:32:09AM -0500, Salyzyn, Mark wrote:
> > But scsi_rescan_device and scsi_scan_host_selected both target specific
> > ids though? As long as we stay away from the wildcards for
> > scsi_scan_host_selected, or am I mistaken?
> 
> scsi_rescan_device should be exported.  For the target scan something
> like the second hunk of James' patch looks good to me.

Why not export scsi_scan_host_selected (and SCAN_WILD_CARD)? If a driver
used it wrong then change the driver.

Suppose a driver wants to scan a given channel. (Would one ever want to
scan for a particular a LUN? I can't think of a reason).

If the driver wants to rescan the host (it knows it it has already
called any scsi scan functions), it would call:

	scsi_scan_host_selected(shost, SCAN_WILD_CARD,
		SCAN_WILD_CARD, SCAN_WILD_CARD, 1);

And new target scan:

	scsi_scan_host_selected(shost, chan, id, SCAN_WILD_CARD, 0);

Target rescan:

	scsi_scan_host_selected(shost, chan, id, SCAN_WILD_CARD, 1);

Instead of any shost->rescan logic.

-- Patrick Mansfield