Re: [patch] sys_stime needs a compat function.

[Arnd Bergmann <arnd@arndb.de>]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

On Dunnersdag 18 November 2004 18:34, Martin Schwidefsky wrote:
>  ia64 doesn't support sys_stime

I'd call that a bug, too.

> and ppc64 has its own sys_stime functions.

This one is identical to the generic sys_stime function (despite the
comment above it), so it should be merged as well.

> +
> +#ifdef __ARCH_WANT_SYS_TIME
> +
> +/*
> + * sys_stime() can be implemented in user-level using
> + * sys_settimeofday().  Is this for backwards compatibility?  If so,
> + * why not move it into the appropriate arch directory (for those
> + * architectures that need it).
> + */
> + 
> +asmlinkage long compat_sys_stime(compat_time_t __user *tptr)

I'd prefer having an extra __ARCH_WANT_COMPAT_SYS_TIME flag. Mips, x86_64,
ia64 and s390 only need compat_sys_stime, but not sys_stime for 64 bit
kernels.
Also, the comment you copied from sys_stime is apparently superceded by
introduction of __ARCH_WANT_XYZ.

	Arnd <><

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]