Re: [PATCH] Kprobes: wrapper to define jprobe.entry

[Ananth N Mavinakayanahalli <ananth@in.ibm.com>]

On Thu, Nov 18, 2004 at 11:05:06PM -0800, Andrew Morton wrote:
> Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote:
> >
> > > >
> >  > > Here is a patch that adds a wrapper for defining jprobe.entry to make
> >  > > it easy to handle the three dword function descriptors defined by the
> >  > > PowerPC ELF ABI.
> >  > > 
> >  > > Current patch against 2.6.10-rc2-mm1 + kprobes patch for ppc64.
> >  > 
> >  > I don't have the kprobes-for-ppc64 patch here.
> >  > 
> >  > > Changes for adding this wrapper for x86, ppc64 (tested) and x86_64 
> >  > > (untested) below. The earlier method of defining jprobe.entry will
> >  > > continue to work.
> >  > 
> >  > So what should I do with this?  I'm inclined to drop it until the x86_64
> >  > part has been tested and Dave has had a go at the sparc64 version.
> > 
> >  I have now tested the patch succesfully on x86_64 and updated it for
> >  sparc64 too (Dave says the change looks good).
> 
> What is the review and testing status of the kprobes-for-ppc64 patch which
> you sent?
> 
The patch was earlier posted on the PPC64 mailing list for comments and 
Paul had reviewed it. I had to update the patch to take care of the base 
kprobe changes that were made to accomodate the x86_64 port.

The patch is tested on POWER3 (uni) and POWER4 (lpar).

Thanks,
Ananth