From: Jens Axboe <axboe@suse.de>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@steeleye.com>
Subject: Re: [PATCH] aacraid bad queuecommand return
Date: Fri, 19 Nov 2004 13:41:27 +0100 [thread overview]
Message-ID: <20041119124126.GD26240@suse.de> (raw)
In-Reply-To: <60807403EABEB443939A5A7AA8A7458B6947FE@otce2k01.adaptec.com>
On Fri, Nov 19 2004, Salyzyn, Mark wrote:
> In the patch I supplied, I dropped the result setting and aac_io_done
> and let the midlayer retry on the none-zero return.
>
> Which is more efficient?
It doesn't really matter - this path should basically never be hit
(or you would have seen a report, it would hang the scsi layer), so
efficiency isn't really an issue. So just do whatever you see fit,
either way will work fine. I like the scsi_done approach best, because
it allows you to flag more fine grained errors.
--
Jens Axboe
next prev parent reply other threads:[~2004-11-19 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 12:32 [PATCH] aacraid bad queuecommand return Salyzyn, Mark
2004-11-19 12:41 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-11-19 12:58 Salyzyn, Mark
2004-11-19 8:59 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041119124126.GD26240@suse.de \
--to=axboe@suse.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.