All of lore.kernel.org
 help / color / mirror / Atom feed
From: maximilian attems <janitor@sternwelten.at>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] convert atmel_cs wireless driver to module_param
Date: Fri, 19 Nov 2004 20:09:51 +0000	[thread overview]
Message-ID: <20041119200951.GH2202@stro.at> (raw)
In-Reply-To: <20041109213307.GD9496@dice.seeling33.de>

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

On Tue, 09 Nov 2004, Stefan Sperling wrote:

> 
> Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.
> 
> --- drivers/net/wireless/atmel_cs.c.orig	2004-11-09 20:40:21.974926616 +0100
> +++ drivers/net/wireless/atmel_cs.c	2004-11-08 23:10:14.000000000 +0100
please as described in Documentation/SubmittingPatches
add one level. thanks :)
> @@ -65,7 +65,7 @@
>  */
>  #ifdef PCMCIA_DEBUG
>  static int pc_debug = PCMCIA_DEBUG;
> -MODULE_PARM(pc_debug, "i");
> +module_param(pc_debug, int, 0644);
>  static char *version = "$Revision: 1.2 $";
>  #define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args);
>  #else
> @@ -86,8 +86,8 @@ MODULE_AUTHOR("Simon Kelley");
>  MODULE_DESCRIPTION("Support for Atmel at76c50x 802.11 wireless ethernet cards.");
>  MODULE_LICENSE("GPL");
>  MODULE_SUPPORTED_DEVICE("Atmel at76c50x PCMCIA cards");
> -MODULE_PARM(irq_mask, "i");
> -MODULE_PARM(irq_list, "1-4i");
> +module_param(irq_mask, int, 0444);
> +module_param_array(irq_list, int, NULL, 0444);

you send on the same driver multiple patches,
is the newere one the better, what's their differences?

a++
maks


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-11-19 20:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-09 21:33 [KJ] [PATCH] convert atmel_cs wireless driver to module_param Stefan Sperling
2004-11-09 23:38 ` Stefan Sperling
2004-11-19 20:09 ` maximilian attems [this message]
2004-11-20  0:15 ` stefan
2004-11-20  0:35 ` maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041119200951.GH2202@stro.at \
    --to=janitor@sternwelten.at \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.