From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefan@binarchy.net Date: Sat, 20 Nov 2004 00:15:11 +0000 Subject: Re: [KJ] [PATCH] convert atmel_cs wireless driver to module_param Message-Id: <20041120001511.GA1400@stud.seeling33.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============59867651701142277==" List-Id: References: <20041109213307.GD9496@dice.seeling33.de> In-Reply-To: <20041109213307.GD9496@dice.seeling33.de> To: kernel-janitors@vger.kernel.org --===============59867651701142277== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 19, 2004 at 09:09:51PM +0100, maximilian attems wrote: > On Tue, 09 Nov 2004, Stefan Sperling wrote: > > > > Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver. > > > > --- drivers/net/wireless/atmel_cs.c.orig 2004-11-09 20:40:21.974926616 +0100 > > +++ drivers/net/wireless/atmel_cs.c 2004-11-08 23:10:14.000000000 +0100 > please as described in Documentation/SubmittingPatches > add one level. thanks :) ouch! > you send on the same driver multiple patches, > is the newere one the better, what's their differences? sorry, my mistake. the newer one is better. The difference is file permissions for /sys entries. The older patch exposed more variables as writable (0644), while the newer one should only make debug and verbosity flags writeable. Unfortunately I had a hard drive crash last week and I thus cannot quickly re-send the patches with -p1. So I'd suggest editing the diff directly, like so: --- a/drivers/net/wireless/atmel_cs.c.orig 2004-11-09 20:40:21.974926616 +0100 +++ b/drivers/net/wireless/atmel_cs.c 2004-11-08 23:10:14.000000000 +0100 regards stefan --===============59867651701142277== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============59867651701142277==--