From: Russell King <rmk@arm.linux.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: icside_dmaintr() in icside.c
Date: Sat, 20 Nov 2004 13:08:18 +0000 [thread overview]
Message-ID: <20041120130817.B13550@flint.arm.linux.org.uk> (raw)
In-Reply-To: <58cb370e041024065467404a38@mail.gmail.com>; from bzolnier@gmail.com on Sun, Oct 24, 2004 at 03:54:54PM +0200
On Sun, Oct 24, 2004 at 03:54:54PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Hi Russell,
>
> * for() loop in icside_dmaintr seems buggy
>
> * what do you think about following patch?
> (ide-dma is nowadays always build if BLK_DEV_IDEDMA)
>
> [ide] icside: use ide_dma_intr()
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Looks fine. I'd have liked to have done it this way initially, but
I seem to remember there were objections to using ide_dma_intr at
the time ("it's for PCI only").
Please push upstream if not already done so.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
prev parent reply other threads:[~2004-11-20 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-24 13:54 icside_dmaintr() in icside.c Bartlomiej Zolnierkiewicz
2004-11-20 13:08 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041120130817.B13550@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.